feat: session management interface - #83
Open
jhbritton-RSK wants to merge 8 commits into
Open
jhbritton-RSK wants to merge 8 commits into
jhbritton-RSK wants to merge 8 commits into
Conversation
jhbritton-RSK
changed the title
jhbritton-RSK
force-pushed
the
feat/40-management-interface
branch
3 times, most recently
from
September 23, 2026 13:15
ad22cd2 to
27cfd99
Compare
|
|
||
| QueryResult<AuthenticationTicketFilterResult> results = await serverSessionTicketStore.FilterServerAuthenticationTickets(filter, ct); | ||
|
|
||
| return results.MapTo<UserSession>(x => x.ToUserSession()); |
Collaborator
There was a problem hiding this comment.
Thoughts on enabling model extensions here similar to #75 ?
Collaborator
There was a problem hiding this comment.
I would agree with this, I can see it being a comment usecase to want to extend session information, adding one item shouldn't need a whole new implementation
Collaborator
patchandthat
requested changes
Sep 23, 2026
patchandthat
left a comment
patchandthat
left a comment
Collaborator
There was a problem hiding this comment.
As per comments. Some comments are for discussion.
jhbritton-RSK
force-pushed
the
feat/40-management-interface
branch
from
September 24, 2026 13:31
018c9b2 to
44dee40
Compare
JoStevensRSK
requested changes
Sep 24, 2026
jhbritton-RSK
force-pushed
the
feat/40-management-interface
branch
from
September 25, 2026 13:51
0e6eb6c to
afbc154
Compare
jhbritton-RSK
force-pushed
the
feat/40-management-interface
branch
from
September 25, 2026 13:55
afbc154 to
2764629
Compare
jhbritton-RSK
marked this pull request as ready for review
September 25, 2026 13:55
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Created the ISessionManagementService interface with compatible methods and signatures. And also created a default implementation.
Type of change
Does this PR introduce a breaking change?
No
Testing
TDD Development with the addition of locally testing the methods
LLM Usage
Used as a quicker search engine and to refactor some small snippets of broken code faster than I could
Other context
Adds to the overall server-side sessions feature in Open.IdentityServer