Repository navigation
Conversation
The ML data manager role is described as able to "manage jobs and export data", but it only held the permission to run an export job, so the exports page offered no way to start one. It now has the same export permissions as the researcher role. Existing projects pick the grant up without a data migration, because create_roles_for_project re-syncs every project's role permissions on post_migrate. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C7Xf6VPbwWtTumhjjF15g8
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for antenna-preview canceled.
|
✅ Deploy Preview for antenna-ssec canceled.
|
|
Claude says: The red "Backend Tests" check on this head is an infrastructure failure, not a code failure. The The image replacement is being handled in #1435. Its last run gets past the image pull, but 17 tests in two classes (the thumbnail views and the pipeline tests against the processing service) still error there. The same two classes error in a local stack when MinIO bucket setup or the processing service is missing, and pass once those are up. Until CI is green again, the test evidence for this PR is a local run of the same CI compose stack, described in the PR description. Please treat the check as blocked on #1435 rather than as a review signal. |
Summary
The ML data manager role is described as able to "manage jobs and export data", but it only held the permission to run an export job, not to create one. The exports page therefore offered ML data managers no way to start an export. This gives the role the same export permissions as the researcher role: create and delete data exports.
Existing projects pick up the change without a data migration, because the role permissions of every project are re-synced on
post_migrate.This is a small product decision as much as a fix, so it is worth a quick yes or no from whoever owns the roles: should ML data managers be able to export data themselves?
List of Changes
MLDataManagerrole inami/users/roles.pygainsCREATE_DATA_EXPORTandDELETE_DATA_EXPORT.How to test
python manage.py test ami.main ami.users(419 tests pass locally).🤖 Generated with Claude Code
https://claude.ai/code/session_01C7Xf6VPbwWtTumhjjF15g8