Repository navigation
Document attaching screenshots to pull requests, and checking new endpoints for per-row queries - #1474
Merged
Conversation
GitHub CLI 2.99 and later uploads images referenced in a PR body and rewrites the references in place, so screenshots no longer need hosting on a branch, fork or bucket. Includes the check for production data in screenshots, since the repository is public. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HEbXiX2mZk7efVmdgSNcN7
✅ Deploy Preview for antenna-preview canceled.
|
✅ Deploy Preview for antenna-ssec canceled.
|
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 17 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The documentation is clear, consistent, and complete.
Review effort: Balanced
Findings: None
What changed in this PR
Documents the durable, privacy-conscious workflow for attaching UI screenshots to pull requests.
Changes:
- Adds
gh --attachinstructions and verification steps. - Warns against exposing production identifiers.
| File | Description |
|---|---|
.agents/AGENTS.md |
Adds screenshot attachment guidance. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…p ci] DefaultSerializer resolves object permissions for every row, so a new list or dropdown serializer can cost several queries per row without anyone noticing, as the job choices did in #1471. The endpoint checklist now says how to opt out or cache per request, and how to test for it. The systemic fix is #1475. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HEbXiX2mZk7efVmdgSNcN7
mihow
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two additions to the agent guide (
CLAUDE.md, which links to.agents/AGENTS.md), both learned while finishing #1471.Screenshots in pull requests have so far been hosted on a branch, a fork, or a storage bucket and then linked, which leaves PRs depending on something that can be deleted. GitHub CLI 2.99 added an
--attachflag that uploads images straight into a PR or issue body, the same way dragging an image into the web editor does. The guide now describes that workflow so future PRs from people and agents use it. It was first used on #1471.The endpoint checklist also gains a line about a query trap that review caught in #1471: every serializer built on
DefaultSerializerworks out the user's permissions separately for each row, so a new list or dropdown serializer can quietly cost several queries per row. The new line says how to avoid it and how to test for it. The fix for all serializers at once is tracked in #1475.List of Changes
gh pr edit --body-file ... --attach ..., including that relative image references in the body are rewritten in place to the uploaded files, and how to check the result.No code changes.
🤖 Generated with Claude Code
https://claude.ai/code/session_01HEbXiX2mZk7efVmdgSNcN7