Repository navigation
Small fixes to the taxa view - #1480
Merged
Merged
Conversation
The taxa table set opacity-50 on every row with at least one verified occurrence, which dimmed the name, dates, counts, images and links of exactly the taxa curators have reviewed most. The shield marker in the Verified column already flags these rows, so the dimming is removed along with the per-row class hook on the shared Table that only it used. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DurLKiG8bGASzdgs6BtxRq
✅ Deploy Preview for antenna-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for antenna-ssec ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 34 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused changes fully implement the described behavior without leaving stale usages.
Review effort: Balanced
Findings: None
What changed in this PR
Removes misleading fading from verified taxa while simplifying the shared table API.
Changes:
- Verified taxa now render at full opacity.
- Removed the unused per-row class callback from
Table.
| File | Description |
|---|---|
ui/src/pages/species/species.tsx |
Stops applying reduced opacity to verified taxa. |
ui/src/nova-ui-kit/components/table/table/table.tsx |
Removes the now-unused rowClassName prop. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
A verified count above zero already shows that a taxon has verified occurrences, so the extra icon repeated the same information. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DurLKiG8bGASzdgs6BtxRq
mihow
changed the title
The taxa list opened in alphabetical order, which puts rarely seen taxa first. It now opens with the most frequently observed taxa at the top. The sessions list opened sorted by occurrence count; it now opens with the most recent session first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DurLKiG8bGASzdgs6BtxRq
mihow
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the Taxa page's table view, every taxon with at least one verified occurrence was drawn at half opacity: the name, the last-seen date, the count bubbles, the images and the links all looked greyed out. That is backwards for the people using the page, because the taxa curators have already confirmed are usually the ones they care about most, and sorting by Verified put a block of faded rows at the top of the list. This change renders those rows normally. It also removes the shield icon next to the verified count, which repeated what the count already says: a verified count above zero means the taxon has verified occurrences.
The dimming came from a miscommunication during #1365, which added tools to help reviewers confirm which species are present. That review aid ended up changing how the Taxa page looks for everyone, even though most people use the page to browse and compare a project's species, not to review them. Styling meant for the review workflow should not change the page's general-purpose view, so the dimming and the extra icon are removed rather than adjusted.
Two default sort orders also change, since both were small and annoying enough not to merit their own PR. The Taxa page now opens with the most frequently observed taxa first (by direct occurrences) instead of alphabetically, and the Sessions page now opens with the most recent session first instead of the session with the most occurrences. Choosing a different sort still works as before.
List of Changes
rowClassNamecallback in the taxa page that appliedopacity-50whennumVerified > 0.useSorton the taxa page changed fromnameascending tooccurrences_countdescending.useSorton the sessions page changed fromoccurrences_countdescending tostartdescending.rowClassNameprop from the shared table component, since the taxa page was its only user.Screenshots
Taxa table sorted by Verified, local copy of the database.
Before: verified rows render at 50% opacity.
After: the same rows at full opacity, with the verified count shown on its own.
How to test
Checks run:
tsc --noEmit,eslintandprettier --checkon the changed files, and the UI jest suite (11 suites, 52 tests passing).🤖 Generated with Claude Code
https://claude.ai/code/session_01DurLKiG8bGASzdgs6BtxRq