[Feat] Handle @roomote mentions on GitLab issues#578
Merged
Conversation
Route GitLab Issue note webhooks into standard-task launch/reuse so @roomote mentions on issues are no longer silent no-ops.
Contributor
Author
|
No new code issues found. See task
Reviewed d8e9992 |
Contributor
Author
|
Fixed host-scoping on GitLab issue task reuse.
Pushed in d8e9992 |
Pass repository host into findReusableGitHubIssueTaskOwner and filter payload sourceControlHost so same-namespace issues on different GitLab instances cannot reuse each other's tasks.
mrubens
marked this pull request as ready for review
July 19, 2026 12:14
mrubens
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
July 19, 2026 12:14
Merged
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Internal P1: GitLab
@roomotementions on issues were a silent no-op.Why this PR exists
What changed
GitLab Note webhooks now handle
@roomotementions on Issues, not only Merge Requests.target.repo.host→ payloadsourceControlHost, with legacy-null tolerance) so same-namespace issues on different GitLab instances cannot cross-matchcreateGitLabIssueNoteHow it was tested
pnpm exec dotenvx run -f .env.test -- pnpm --filter @roomote/api exec vitest run src/handlers/gitlab/__tests__/handleNote.test.ts(24 passed)pnpm exec dotenvx run -f .env.test -- pnpm --filter @roomote/db exec vitest run src/lib/__tests__/github-branch-activity.test.ts -t "findReusableGitHubIssueTaskOwner"(6 passed)oxlint, residual lint,check-types:fast, knip) passed on pushChecklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changeset