Make RateStore marshalable (add #marshal_dump)#31
Open
jtarchie wants to merge 1 commit into
Open
Conversation
sunny
approved these changes
Jul 22, 2026
Money::Bank::VariableExchange#marshal_load rebuilds the store with store_info.shift.new(*store_info), which requires the store's #marshal_dump to return [StoreClass, *constructor_args]. Without it, marshaling a bank whose store is a RateStore fails, which happens when the configured default bank is cached under a Marshal-based serializer. RateStore takes no constructor arguments, so returning [self.class] is enough to rebuild it on load.
jtarchie
force-pushed
the
marshalable-rate-store
branch
from
July 22, 2026 16:21
4c78826 to
ded6a67
Compare
Author
|
Thanks for the quick review! Rebased onto the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Marshaling a
Money::Bank::VariableExchangewhose store is anActiveCurrency::RateStorefails, becauseRateStorehas no#marshal_dump.VariableExchange#marshal_loadrebuilds the store with:so it expects the store's
#marshal_dumpto return[StoreClass, *constructor_args]. Without a custom#marshal_dump,reloading a marshaled bank raises.
This comes up when the configured
default_bankuses aRateStoreandsomething marshals it, e.g. a Rails app with a Marshal-based cache or
message serializer that caches the default bank.
Fix
Add
#marshal_dumptoRateStorereturning[self.class].RateStoretakes no constructor arguments, so that is all
VariableExchange#marshal_loadneeds to rebuild it on load.
Test
Added specs asserting
RateStore#marshal_dumpreturns[described_class]and that a
VariableExchangebacked by aRateStoreround-trips throughMarshal.