Skip to content

Shorten PID controller test simulation - #616

Merged
RussTedrake merged 1 commit into
masterfrom
codex/mac-pid-test-runtime
Sep 29, 2026
Merged

RussTedrake merged 1 commit into
masterfrom
codex/mac-pid-test-runtime

Conversation

@RussTedrake

@RussTedrake RussTedrake commented Sep 29, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Shorten the PID controller grading simulation from 2.0 s to 1.25 s.
  • Keep the 1e-4 s plant time step, controller gains, and existing final-position assertion unchanged.

Verification

  • solutions/notebooks/robot/test_notebooks_solutions_robot.py::test_04_pid_controller passed locally (1 passed). The local run used a temporary localhost Meshcat port override because port 7000 was already occupied, plus model packages prefetched to /tmp.
  • Headless simulation experiment at the unchanged 1e-4 s time step produced a final-position error norm of 0.01833 at 1.25 s (assertion limit: 0.05).
  • Pre-commit hooks passed.

This change is Reviewable

@RussTedrake
RussTedrake merged commit dc1281c into master Sep 29, 2026
5 checks passed
@RussTedrake
RussTedrake deleted the codex/mac-pid-test-runtime branch September 29, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant