feat: switch from num-bigint-dig to crypto-bigint - #394
Merged
Merged
Conversation
tarcieri
reviewed
Nov 29, 2023
tarcieri
reviewed
Dec 1, 2023
Member
|
@dignifiedquire can we land this? |
Contributor
|
There's a minor thing of needing the |
Contributor
|
Also the 6-10x performance drop is quite surprising, but that can be addressed in a follow-up as well. |
Member
Author
I removed that, there is some other follow ups from you and @tarcieri I wanted to get to, but we can also merge as is |
Member
Author
|
Thank you everyone who helped make this a reality! And sorry for this taking so long.. |
Merged
tarcieri
added a commit
that referenced
this pull request
Feb 14, 2025
Notably includes #394 which migrates to `crypto-bigint`
This was referenced Apr 27, 2025
takumi-earth
pushed a commit
to earthlings-dev/RSA
that referenced
this pull request
Jan 27, 2026
Notably includes RustCrypto#394 which migrates to `crypto-bigint`
This was referenced Sep 12, 2026
Open
This was referenced Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very, very WIPNot anymore, this is ready for review.
Replaces all usage of
num-bigint-digbasedBigIntusage with the newcrypto-bigintcrate, usingBoxedUintCurrent known issue is that we do have a performance regression, which will be able to get rid of over time:
TODOs
RsaPrivateKeyRsaPublicKeydecryptimplementationBigUintto return owned versions