Repository navigation
[release] hotfix 1.0.6: restore the greeter helper's exec bit on ISO installs - #650
Merged
Merged
Conversation
mkarchiso copies the airootfs with --no-preserve=mode, so the payload's qylock bundle reaches the target with every file at 0644. The greeter helper 1.0.6 added (sddm-host/install-greeter-theme) is executed directly by install-qylock, so every Arch and CachyOS ISO install died at the configure stage with "Permission denied" (exit 126). Restore its bit next to the existing chmod of the two staged installers. Verified: the shipped v1.0.6 CachyOS ISO fails exactly there in QEMU; the same ISO with this backend overlaid installs (BACKEND_EXIT:0) and boots the installed CachyOS kernel to the login prompt. Note: Fixed: Arch and CachyOS ISO installs stopped at the sign-in screen setup with a Permission denied error; they now finish and boot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every v1.0.6 Arch and CachyOS ISO install stops at the configure stage:
mkarchiso copies the airootfs with
cp -af --no-preserve=ownership,mode, sothe baked payload ships every file at 0644 (confirmed in the served ISO's
squashfs). The greeter helper added in this release line is executed
directly, so it needs its bit restored after the bundle copy, the same way
the backend already restores it on the two installers it stages.
Proof: the shipped CachyOS ISO reproduces the failure in QEMU; with this
backend overlaid, the same ISO installs (BACKEND_EXIT:0) and boots
CachyOS 7.2.7-1-cachyosto the login prompt. The plain ISO failsidentically in install-test run 40775430183. Cherry-picks 8583339 from
unstable-dev. The installer payload is the only thing that changes; the
Arch and CachyOS ISOs get rebuilt on the moved tag after this merges.