Repository navigation
Land lyrics romanization (#23) - #24
Merged
Merged
Conversation
…jabi lines An opt-in setting (lyrics_romanize, off by default) shows a Latin reading under each lyrics line, between the line and its translation, in the QML client and the Svelte UI. - crates/core/src/romanize.rs: script detected once per song; Korean (Revised Romanization), Cyrillic (7 languages), Devanagari and Gurmukhi are rule/table based, Chinese uses the pinyin crate (plain table only). Japanese songs are left alone so kanji-only lines never get pinyin. - Applied in get_lyrics on the daemon and the Tauri host only: the lyrics cache and downloaded .lrc files stay untouched, and old cache entries still parse. - Ported from PeekMusic (Metrolist fork, GPL-3.0) with fixes: merged Korean final/initial pairs, Hindi inherent vowel and schwa deletion, Russian -ого. Release ryotunesd grows by 302 KiB (+1.0 %).
Flipping lyrics_romanize now emits a one-shot lyrics-changed event from the daemon and the Tauri host. Open lyrics views (sidebar, Now Playing, mini player) refetch the current track from the cache and swap the lines in place: no loading state, the offset is kept, and the view lands back on the active line before the frame is drawn. A hidden view refetches when it is shown again, and a fetch already in flight is followed by one more.
The reading takes the line's state colour a step softer and drops the plain line's trailing leading; songs with readings get more space between line pairs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands #23 with one fix on top so a lyrics refresh that arrives while the first load is still running isn't dropped.
Closes nothing on its own, #22 is a Spotify side refusal with no librespot fix yet.