Repository navigation
feat(auth): implement login, register, and verify-email flows - #14
Merged
Merged
Conversation
Resolves SATR-ATM#11 - Build responsive AuthLayout matching Figma (desktop, tablet, mobile) - Create reusable FormField and PasswordInput components - Integrate React Hook Form and Zod for inline validation - Add SocialLoginButtons placeholders with official SVGs - Implement a11y improvements (aria-labels) for E2E resilience
…while writing the code
MohamedMouloudj
requested changes
Aug 19, 2026
Member
There was a problem hiding this comment.
- Use media from Figma and fix button direction on auth pages
- Use lucide icons (I installed it for you) instead of hardcoded svg icons
- Respect the backend endpoints, you can run docker containers for quick setup
- Check the pushed test to know how to pass and what is expected
- Read newly created DEVELOPMENT.md for more clarification
- In reset password page, the time must be tied to backend to avoid alteration from client side, just use mock data for now, but take in consideration that the mock should be easily replaced with real backend call
…hydration fix, and lucide icons
Member
|
7 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #11
Linked Issue
Closes #11
GitHub Project
Description 📑
Implements the complete authentication UI for the parent web dashboard as specified in Issue #11.
All pages (
/login,/register,/verify-email,/forgot-password,/add-child) are built with a shared responsive layout that splits 44/56 on desktop, 50/50 on tablet, and stacks vertically on mobile (hero section first for better UX).Form validation is handled entirely client-side via Zod schemas + React Hook Form, with inline field-level errors. Social login buttons (Google/Apple) are present as visual placeholders only — logic is not implemented per spec.
All interactive elements have
aria-labelattributes, making them immediately usable in Playwright E2E tests.Type of Change
Changes
app/(auth)/layout.tsxapp/(auth)/login/page.tsxapp/(auth)/register/page.tsxapp/(auth)/verify-email/page.tsxapp/(auth)/forgot-password/page.tsxapp/(auth)/add-child/page.tsxapp/dashboard/page.tsxcomponents/ui/FormField.tsxcomponents/ui/PasswordInput.tsxcomponents/auth/AuthSideHero.tsxcomponents/auth/SocialLoginButtons.tsxcomponents/ui/ElFulkLogo.tsxlib/schemas/auth.tsloginSchema,registerSchemapackage.json+pnpm-lock.yamlScreenshots / Demos 📷
|




|
|
|
|
How to test 🚦
pnpm installthenpnpm dev/register→ fill form → submit → redirects to/verify-email/login→ fill email + password → submit → redirects to/dashboard/forgot-password→ verify link back to/loginexists