Skip to content

#666 Redesign The Edit Position Page #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
b-at-neu merged 13 commits into from
Sep 12, 2026
Merged

#666 Redesign The Edit Position Page #690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
654679e
#666 redesign edit position page as one page with autosave
b-at-neu Sep 8, 2026
524f412
#666 address review feedback
b-at-neu Sep 8, 2026
79aee59
#666 apply layout feedback to the edit position page
b-at-neu Sep 8, 2026
07f01b6
#666 fix edit-position loading skeleton to match current layout
b-at-neu Sep 8, 2026
e3d0ba4
#666 address review feedback
b-at-neu Sep 12, 2026
bf4b138
#666 address review feedback
b-at-neu Sep 12, 2026
be0cc88
#666 apply post-approval human feedback on edit position page
b-at-neu Sep 12, 2026
0684773
#666 gate live-edit warning bar on canEdit
b-at-neu Sep 12, 2026
ab3d8f2
#666 fix section card header padding and reopen button label
b-at-neu Sep 12, 2026
479b7aa
#666 address review feedback
b-at-neu Sep 12, 2026
ab1b5b4
#666 fix missed reopen position rename in workflows doc
b-at-neu Sep 12, 2026
ec04328
#666 force SectionCard header padding to beat CardHeader's border-b rule
b-at-neu Sep 12, 2026
5dead6e
#666 collapse SectionCard header to one grid row
b-at-neu Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 19 additions & 37 deletions app/(main)/(auth)/manage/positions/[id]/edit/loading.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,52 +1,34 @@
import { SectionCardSkeleton } from '@/components/ui/section-card';
import { Skeleton } from '@/components/ui/skeleton';

export default function EditPositionLoading() {
return (
<div className="mx-auto flex max-w-2xl flex-col gap-6">
{/* PageHeader skeleton: back link + title + description */}
<div className="mx-auto flex max-w-5xl flex-col gap-4">
{/* PageHeader skeleton: back link + title + badge, one action bar */}
<div className="flex flex-col gap-1">
<Skeleton className="mb-1 h-7 w-32" />
<Skeleton className="h-8 w-56" />
<div className="flex flex-col gap-3 sm:flex-row sm:items-start sm:justify-between">
<div className="flex items-center gap-2">
<Skeleton className="h-8 w-56" />
<Skeleton className="h-5 w-16 rounded-md" />
</div>
<Skeleton className="h-9 w-40" />
</div>
<Skeleton className="h-4 w-24" />
</div>

<div className="flex flex-col gap-4">
{/* Tab bar skeleton */}
<div className="flex gap-1 rounded-lg border p-1">
<Skeleton className="h-8 flex-1" />
<Skeleton className="h-8 flex-1" />
<Skeleton className="h-8 flex-1" />
</div>
{/* Details + Availability merged card */}
<SectionCardSkeleton rowShape="form-field" rows={4} hasLink={false} />

{/* Tab content skeleton — loose shape fits both the editable form and the archived read-only view */}
<div className="mt-2 flex flex-col gap-4">
<div className="flex flex-col gap-2">
<Skeleton className="h-4 w-12" />
<Skeleton className="h-9 w-full" />
</div>
<div className="flex flex-col gap-2">
<Skeleton className="h-4 w-20" />
<Skeleton className="h-24 w-full" />
</div>
<div className="flex flex-col gap-2">
<Skeleton className="h-4 w-12" />
<Skeleton className="h-9 w-full" />
</div>
<div className="flex flex-col gap-2">
<Skeleton className="h-4 w-20" />
<Skeleton className="h-9 w-full" />
</div>
<div className="flex flex-col gap-2">
<Skeleton className="h-4 w-20" />
<Skeleton className="h-9 w-full" />
</div>
<Skeleton className="h-9 w-32" />
</div>
{/* Managers / Questions grid */}
<div className="grid gap-4 md:grid-cols-2">
<SectionCardSkeleton rowShape="form-field" rows={1} hasLink={false} />
<SectionCardSkeleton rowShape="form-field" rows={3} hasLink={false} />
</div>

{/* Danger zone skeleton — admin-only, shown speculatively to avoid layout shift */}
<div className="flex flex-col gap-3 rounded-xl border p-6">
<Skeleton className="h-5 w-32" />
{/* Danger zone skeleton — compact, admin-only, shown speculatively to avoid layout shift */}
<div className="flex flex-col gap-2 rounded-xl border p-4">
<Skeleton className="h-4 w-32" />
<Skeleton className="h-9 w-36" />
</div>
</div>
Expand Down
Loading
Loading