Skip to content

fix: Slack reminder wording (#104), Alternate Room and Time (#105), and bump to v1.14.2 - #106

Merged
pataniaeli merged 3 commits into
devfrom
fix/issue-104-105-v1.14.2
Sep 14, 2026
Merged

pataniaeli merged 3 commits into
devfrom
fix/issue-104-105-v1.14.2

Conversation

@pataniaeli

Copy link
Copy Markdown
Collaborator

Closes #104
Closes #105

#105 — Alternate Room and Time

  • New status directly under Alternate Time in all six booking forms, with the same #4285f4 blue in every colour map (bookings tab, weekly grid, My Rooms, archive, audit).
  • Needs a migration. one_time_room_bookings, weekly_room_bookings, weekly_room_occurrences and tabling_sessions each have a CHECK constraint listing the allowed statuses. supabase/migrations/20260914000000_alternate_room_and_time_status.sql widens all four. Apply it before this deploys, or saving a booking with the new status fails. It only widens the constraints, so the code running now keeps working with it applied. The rollback moves any such rows to Alternate Room first.

#104 — Committee Slack reminder wording

Status Message
Reserved *Committee* meets tomorrow! Join us on Tuesday, September 15. / Room: … / Time: …
Alternate Room / Time / Room and Time Same, with *Alternate* in front of whichever line changed (both lines for Room and Time)
Virtual Opening line + Check with your Chair/Director for virtual meeting information.
Cancelled *Committee* has no meeting tomorrow.
Anything else No message

Behaviour changes: Cancelled used to be skipped and now posts. Pending Cancellation used to post and now doesn't. The purpose and status lines and the emoji are gone. Hidden bookings are still never announced.

Checked by running the formatter for all 12 statuses. The output matches the issue text.

Version

v1.14.2 in package.json, the lockfile root, and the sidebar, plus a member-facing FAQ entry.

Verification

  • tsc --noEmit clean, next build succeeds
  • Changed files add no new lint errors. The two errors ESLint reports in them (setState in an effect) were already there.

🤖 Generated with Claude Code

pataniaeli and others added 3 commits September 14, 2026 14:33
A booking could be given an alternate room or an alternate time, but not
both, though CSC does hand out both at once. The new status sits directly
under Alternate Time in every status list, and takes the same blue in every
colour map as the other two alternates.

The four tables that carry a booking status each have a CHECK constraint
spelling out the vocabulary, so the migration replaces all four. It has to be
applied before this deploys, or saving a booking with the new status fails
the check. The rollback folds any such rows into Alternate Room before
restoring the old constraints.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…atuses (#104)

The reminder now reads the way the issue sets out:

  Reserved         "<Committee> meets tomorrow! Join us on <date>." then the
                   room and time, each on its own line.
  Alternate ...    The same, with a bold "Alternate" on whichever of the room
                   and time moved -- both, for Alternate Room and Time (#105).
  Virtual          The opening line, then a pointer to the Chair or Director
                   for the meeting details, and no room.
  Cancelled        "<Committee> has no meeting tomorrow."

The calendar emoji, the purpose and the status line are gone.

Which statuses post is now an allow-list rather than a block-list. Anything
else -- Waitlisted, Tentative, Pending Cancellation, Unavailable, Missed,
Repurposed -- posts nothing, and so will any status added later until someone
decides what it should say. Cancelled used to be skipped and now posts, since
telling a channel its meeting is off is the point of that message. Pending
Cancellation used to post with its status shown, and now does not.

A hidden booking is still never announced, cancelled or not. Purpose is no
longer read by the query, since nothing prints it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
package.json, the lockfile's two root entries, and the sidebar label.

A patch: Alternate Room and Time (#105) fills a gap in a vocabulary that
already existed, and the Slack reminder wording (#104) revises a message
rather than adding one. The FAQ entry is written for members, and names that
waitlisted, tentative and pending-cancellation weeks no longer get a reminder,
since a channel that used to hear about those will now hear nothing.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
chambers Ready Ready Preview Sep 14, 2026 8:38pm UTC

@pataniaeli pataniaeli self-assigned this Sep 14, 2026
@pataniaeli pataniaeli added enhancement New feature or request revision Nothing is broken, but something needs to be resolved labels Sep 14, 2026
@pataniaeli
pataniaeli merged commit 0eb1892 into dev Sep 14, 2026
4 checks passed
@pataniaeli
pataniaeli deleted the fix/issue-104-105-v1.14.2 branch September 14, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request revision Nothing is broken, but something needs to be resolved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create "Alternate Room and Time" Revise automatic Slack bot alert text

1 participant