Repository navigation
merge patches from 2.10.2 - #17
Open
paulopamplona wants to merge 7 commits into
Open
paulopamplona wants to merge 7 commits into
paulopamplona wants to merge 7 commits into
Conversation
* Diff test names against the PR's actual base The test name check runs on `pull_request_target`, where the bare `actions/checkout` lands on the default branch rather than the branch the pull request targets. Taking the merge base from `HEAD` therefore compares against `main` no matter what the pull request is based on, and every commit another base branch carries that `main` lacks gets attributed to the pull request. Almost every Argus pull request targets `main`, so the wrong baseline happens to be the right one and this rarely shows. It misfires on anything based on a branch such as `alpha/2.0.x`. The identical bug in NAV was live rather than latent, because bugfixes there routinely target a version branch, and the check reported pre-existing tests as new on every one of them. Take the merge base from the pull request's own base branch instead. The checkout is deliberately left alone, so `check_test_names.py` keeps coming from the default branch and the job keeps working even when a base branch predates the script. * Document why this job must not check out PR code `pull_request_target` gives this job a write token and access to secrets even for pull requests from forks. That is safe only for as long as nothing from the pull request is checked out or executed here, which is an invariant the file states nowhere. Adding a `ref:` to the checkout looks like an obvious correctness fix to anyone reading the step in isolation, and would silently turn this into a workflow that runs fork-authored code with our credentials. Say so where someone would make the change.
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 7.0.1 to 7.0.2. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@043fb46...cf430e0) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: 7.0.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [EnricoMi/publish-unit-test-result-action](https://github.com/enricomi/publish-unit-test-result-action) from 2.24.0 to 2.25.0. - [Release notes](https://github.com/enricomi/publish-unit-test-result-action/releases) - [Commits](EnricoMi/publish-unit-test-result-action@d0a4676...7622c5b) --- updated-dependencies: - dependency-name: EnricoMi/publish-unit-test-result-action dependency-version: 2.25.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/create-github-app-token](https://github.com/actions/create-github-app-token) from 3.2.0 to 3.3.0. - [Release notes](https://github.com/actions/create-github-app-token/releases) - [Changelog](https://github.com/actions/create-github-app-token/blob/main/CHANGELOG.md) - [Commits](actions/create-github-app-token@bcd2ba4...64ab729) --- updated-dependencies: - dependency-name: actions/create-github-app-token dependency-version: 3.3.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
The "4 is the magic eMudhra number" release
|
Warning 2 of 11 new test names are missing convention keywords (
Why am I seeing this?Test names should follow a loose given/when/then pattern with keywords like Examples:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and purpose
Fixes #. Dependent on #.
Add a description of what this PR does and why it is needed. If a linked ticket(s) fully
cover it, you can omit this.
This pull request
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.