Repository navigation
Retire legacy ethers signing patch and verify retained SDK safety contracts - #53
Conversation
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Replace the signing-key dependency package.json, patches/@ethersproject+signing-key@5.8.0.patch, tests/boundary/legacy-dependency-replacements.test.ts, tests/boundary/wallet-runtime-boundary.test.ts |
The package override supplies ethers 6.17.0 for the hash package’s type-only dependency. The signing-key patch and its package entry are removed. Boundary tests check dependency imports, declarations, encoding, signing, and recovery. |
Update the compatibility record docs/engineering/sdk-package-upgrades.md, docs/engineering/review-findings-follow-up-2026-10-26.md |
The docs record the patch retirement and reduced count, and describe remaining SDK compatibility requirements and review findings. |
Atomic Publication Boundary Tests
| Layer / File(s) | Summary |
|---|---|
Check atomic publication boundaries tests/boundary/sdk-atomic-publication.test.ts |
New tests cover concurrent asynchronous writes, exclusive writes, and symlink targets at the former predictable temporary filename. |
Priority:
Estimated code review effort: 3 (Moderate) | ~20 minutes
Change: Other
Possibly related PRs
- SYMBaiEX/doolittle#49: Updates the same SDK compatibility inventory and records the patch retirement from seven to six.
- SYMBaiEX/doolittle#47: Continues the SDK compatibility patch retirement and updates the package graph.
- SYMBaiEX/doolittle#52: Adds the reliability follow-up that this PR updates with further regression evidence.
Merge Risk: 
77c15
-
The new boundary tests can run through the supported workflows, and no actionable issue remains before merge.
Pre-merge checks: 
-
Check name Status Explanation Resolution Docstring Coverage Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 3 files. (3 skipped: 3 … Write docstrings for the functions missing them to satisfy the coverage threshold. Description check The description provides a detailed outcome, scope, compatibility rationale, verification results, and CI status. It does not use the required template headings, list exact validation commands and res… Rewrite the description using the required Outcome, Scope, Verification, and Risk and rollback sections. Include the ElizaOS primitive or compatibility boundary, exact commands with results, each applicable verification checkbox, and explic… -
Check name Status Explanation Title check The title clearly describes the primary change: retiring the legacy ethers signing patch and verifying retained SDK safety contracts. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 3 files. (3 skipped: 3 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Full details: Description check
-
Explanation
The description provides a detailed outcome, scope, compatibility rationale, verification results, and CI status. It does not use the required template headings, list exact validation commands and results, or describe compatibility, migration, security, release, and rollback considerations.
Resolution
Rewrite the description using the required Outcome, Scope, Verification, and Risk and rollback sections. Include the ElizaOS primitive or compatibility boundary, exact commands with results, each applicable verification checkbox, and explicit compatibility, migration, security, release, and rollback considerations.
-
Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Retires the ethers signing-key patch by removing its only incoming legacy dependency chain. The hash package imports the signer dependency only in its domain/field declarations; a scoped alias supplies the current official ethers package. Its runtime hashing code remains unmodified, and the wallet plugin continues using ethers 6 for signing.
The lockfile regenerates peer contexts and reconciles existing peer selections. SDK package selections are unchanged.
Local validation: 194 boundary tests; all workspace/tooling types, lint, acceptance checks and zero-production-advisory policy passed. Seven source-runtime tests and four native desktop journeys passed. Real linked-Codex coding passed through ElizaOS in CLI (33.4s) and desktop (49.9s), with source repair independently verified. Wallet action imports, Uniswap calldata, signing and typed-data recovery passed offline; no transactions were submitted. Final PR CI passed, including CodeQL, clean-HEAD packaged acceptance and native Windows provider lifecycle behavior.
Summary by CodeRabbit