AGC Restart Fix#16
Merged
Merged
Conversation
preserve the auto gain control setting when the RNNoise path restarts the mic track
7w1
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
Pass the user's auto gain control setting when the RNNoise path restarts the microphone track, and add a regression test for it.
Motivation and context
Restarting the mic track (e.g. toggling RNNoise noise suppression) rebuilt it without the saved AGC preference, silently re-enabling AGC for users who had turned it off.
Screenshots / GIFs
N/A
Tests
Added a unit test covering the restart path in Publisher.test.ts.
Typecheck and the full unit suite pass locally (node 24, mirroring CI).