1577 Add generic Time Series Plotting function - #1589
kilianvolmer wants to merge 5 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1589 +/- ##
==========================================
- Coverage 97.48% 97.47% -0.02%
==========================================
Files 190 190
Lines 16035 16035
==========================================
- Hits 15632 15630 -2
- Misses 403 405 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
HenrZu
left a comment
There was a problem hiding this comment.
Thank you for this great addition. Just some short comments.
I think one limitation of this package is, that we need to install this additionally to the simulation package, as some of the examples even require the plot package to be installed.
It would be great, if we add this as an optional dependency in the pyproject toml of the simulation package.
[project.optional-dependencies]
dev = []
plot = ["memilio-plot"]
Also, the plot packages requires (requires-python = ">=3.9") and the simulation package has (requires-python = ">=3.8"). (however PyPI says >=3.9)
| region_results = [region0_result, region1_result] | ||
| region_labels = ['Region 0', 'Region 1'] | ||
|
|
||
| # All compartments of each region on a logarithmic axis. |
There was a problem hiding this comment.
good catch. I removed this on purpose but forgot about the comment. Do you want it to be plotted on a log axis?
Thank you for the comment! I will add it as a dependency. However, I think we should also think about actually adding the plot package to our pypi package now. |
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #1577