Skip to content

1590 Add UncertainValue operators to bindings - #1591

Merged
HenrZu merged 3 commits into
mainfrom
1590-add-uncertainvalue-operators-to-bindings
Oct 1, 2026
Merged

HenrZu merged 3 commits into
mainfrom
1590-add-uncertainvalue-operators-to-bindings

Conversation

@reneSchm

@reneSchm reneSchm commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • Add arithmetic operators for UncertainValue to the Python bindings
  • The in-place operators +=, -=, *=, /= are changing the UncertainValue in place without copy

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below).
  • New code adheres to coding guidelines.
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.).
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP).
  • Appropriate documentation within the code (Doxygen) for new functionality has been added in the code.
  • Appropriate external documentation (ReadTheDocs) for new functionality has been added to the online documentation and checked in the preview.
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added.
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed.
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.).
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease).
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.).
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

@reneSchm reneSchm linked an issue Sep 30, 2026 that may be closed by this pull request
2 tasks done
@reneSchm
reneSchm requested a review from HenrZu September 30, 2026 12:11
@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.47%. Comparing base (2664e8c) to head (da6ee17).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1591      +/-   ##
==========================================
- Coverage   97.48%   97.47%   -0.02%     
==========================================
  Files         190      190              
  Lines       16035    16035              
==========================================
- Hits        15632    15630       -2     
- Misses        403      405       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HenrZu HenrZu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition. One additional test to check that the i_operators are done in inplace.

Comment thread pycode/memilio-simulation/tests/test_uncertain_value.py
Co-authored-by: Henrik Zunker <69154294+HenrZu@users.noreply.github.com>
@HenrZu
HenrZu merged commit f1d76f8 into main Oct 1, 2026
64 checks passed
@HenrZu
HenrZu deleted the 1590-add-uncertainvalue-operators-to-bindings branch October 1, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add UncertainValue operators to bindings

2 participants