Repository navigation
refactor(pycdfpp): use cpp_utils_python numpy/datetime helpers - #138
Merged
Merged
Conversation
Deletes the numpy no-zero-fill allocation and the generic datetime.datetime <-> time point code that now live in cpp_utils_python, and forwards to them: fast_allocate_array keeps its (shape, optional owner) signature, py_datetime and its caster are imported, to_datetime / to_time_point replace the local _details::to_tp. No public API change; CDF-typed conversions stay in pycdfpp. Local check used subprojects/cpp_utils as a symlink to the cpp_utils feat/cpp-utils-python worktree (git-ignored, not committed). The cpp_utils.wrap revision bump waits until that branch is pushed. Co-Authored-By: OpenCode <noreply@opencode.ai>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tested: pycdfpp suite 55/55 against this revision. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
==========================================
+ Coverage 96.24% 96.25% +0.01%
==========================================
Files 94 94
Lines 9208 9184 -24
==========================================
- Hits 8862 8840 -22
+ Misses 346 344 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generic numpy and datetime helpers moved from pycdfpp to cpp_utils (
cpp_utils/cpp_utils_python/), so CEFast (SciQLop/CEFast) can share them.fast_allocate_array(numpy array without zero-fill) now comes from cpp_utils.No behaviour change: pycdfpp suite 55/55, same as main, built with cpp_utils fetched from the wrap.
🤖 Generated with Claude Code