Repository navigation
axolotl-launcher-beta: Add version 1.11.0-beta.1 - #1837
xinvxueyuan wants to merge 7 commits into
Conversation
…l-Launcher Adds a beta-channel manifest (bucket/axolotl-launcher-beta.json) for the Axolotl Launcher v1.10.0-beta.5 release from the Axolotl-Launcher/Axolotl organization (the project's new home after migrating from Mystic-Stars/Axolotl). The manifest is cloned from the stable axolotl-launcher.json (extract_dir, pre_install data-migration script, persist, bin/shortcuts naming) with the repository addresses updated and version/url/hash set for the beta asset. Hash is the SHA256 of the released portable zip. Closes ScoopInstaller#1836
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Beta package download bucket/axolotl-launcher-beta.json |
Adds beta package metadata, a WebView2 suggestion, and the 64-bit portable archive URL and SHA-256 hash. |
Data migration and persistence bucket/axolotl-launcher-beta.json |
When the persistent target is absent and the legacy AppData directory exists, pre-install migration copies the data through a staging directory. Migration stops if the launcher is running. On failure, it removes staging data and rethrows the error. The manifest also adds the launcher alias, shortcut, and persistence mapping. |
Prerelease update checks bucket/axolotl-launcher-beta.json |
Adds beta-release version checks using prerelease GitHub tags and autoupdate URLs for the archive and its SHA-256 hash. |
Merge Risk: 
Minimal · previous review e4f1e
-
The beta manifest is ready to merge; no actionable current-head risk was identified.
Pre-merge checks: 
5
-
Full details: Title check
-
Explanation
The title "axolotl-launcher-beta: Add version 1.11.0-beta.1" names the package and the change: a new beta manifest at version 1.11.0-beta.1. The raw summary describes the new manifest for that beta release, so the title matches the main change. However, the PR objectives and description cite version 1.10.0-beta.5 as the version checkver finds, so the title's version may not match the version the manifest actually carries. This is a discrepancy to verify, not a reason to fail the title.
Full details: Description check
-
Explanation
The description follows the repository template in substance. It has an Overview, a Testing section, a "Closes
#1833" line, and a checked Contributing Guide box. It explains the separate beta manifest, its shim and Start Menu entry, and the checkver approach. It also lists the validation commands and their results. The template's comment block about opening a related issue first is satisfied by the link to#1833. The version named in testing (1.10.0-beta.5) differs from the title and the summary (1.11.0-beta.1), which the author should reconcile.
Full details: Linked Issues check
-
Explanation
Issue
#1833requires a separate Scoop manifest for the Axolotl Launcher beta channel. The PR addsbucket/axolotl-launcher-beta.jsonwith a beta-specific download, shim, and Start Menu entry. Its update check selects prerelease releases. The stableaxolotl-launchermanifest remains unchanged. These changes satisfy the linked coding requirements.
Full details: Out of Scope Changes check
-
Explanation
The whole-PR summary identifies one added manifest. Its download, checksum, prerelease update logic, shim, shortcut, persistence, and migration behavior support the separate beta package requested by issue
#1833. No unrelated change is demonstrated.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
There was a problem hiding this comment.
ℹ️ Review info
⚙️ Run configuration
- Source mode: Auto
- Repository: Unavailable
- Branch: Unavailable
- File: No configuration file from this repository applied
- Commit: Unavailable
- Layers: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
ffff27d2-f2b5-4f5c-a025-30052b3ec41c
📒 Files selected for processing: 1
bucket/axolotl-launcher-beta.json
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.
…ses in checkver Rebuild the manifest from the upstream stable original instead of retyping it, so pre_install keeps its " and \\ escaping and the file parses as JSON. checkver previously pointed at the repository URL, which Scoop resolves through /releases/latest and therefore always returns the stable release; the default regex also drops the -beta suffix. Use the releases API with a jsonpath filter on prerelease == true, matching the existing -beta convention in this bucket.
|
/verify |
|
All changes look good. Wait for review from human collaborators. axolotl-launcher-beta
|
Move the releases URL from `checkver.url` to `checkver.github`. Scoop only attaches the GitHub token (GITHUB_TOKEN / GH_TOKEN, as supplied by Excavator) in the `checkver.github` branch; a plain `checkver.url` request is unauthenticated and fails once GitHub's 60/hour unauthenticated quota for the shared runner IP is exhausted. The URL is already a full `api.github.com/repos/...` endpoint, so the `/releases/latest` rewrite is not applied and the custom jsonpath prerelease filter and regex are unchanged. This matches the existing `apngasm` / `aptos-cli` / `maaend-beta` patterns in the Scoop buckets. Verified: `checkver` still reports 1.11.0-beta.1, `checkver -Update` resolves the same prerelease asset, and the schema test passes.
The hash is the published SHA-256 of the portable zip, taken from the release metadata instead of being computed locally: GitHub Release asset.digest, update.axlmc.org/api/downloads/latest?channel=beta and the website release metadata all agree on fce9603f. Note latest.json is not a suitable source here. Its platforms.windows-x86_64 entry points at Axolotl.Launcher_<version>_x64-setup.nsis.zip (the Tauri updater payload), not at the Axolotl_Launcher_<version>_x64_portable.zip this manifest installs, and the two archives have different digests. Verified: checkver/checkurls/checkhashes OK, Pester 429/429, and `checkver -Update -ForceUpdate` reproduces this exact hash from the GitHub release digest.
…data Release metadata now publishes the portable zip digest, so Excavator no longer has to download the 95 MB archive to hash it. The jsonpath picks artifacts.portable.sha256 out of the tagged latest.json, which is the same value this manifest already carries. Scoop falls back to downloading and hashing when the path yields nothing, so releases predating the artifacts field still update; it only costs the download those releases already paid for.
…ase metadata" This reverts commit e4f1e4a.
Overview
axolotl-launcher-beta, the pre-release channel of Axolotl Launcher, as requested in [Request]: Axolotl Launcher Beta #1833.axolotl-launchermanifest so the two cannot overwrite each other: it gets its own shim (axolotl-launcher-beta) and Start Menu entry (Axolotl Launcher (Beta)).version/url/hash/checkveris derived from the existing stable manifest, soextract_dir, thepre_installAppData migration andpersistbehave exactly as they already do.checkverreads the releases API and filters onprerelease == true, the approach already used bymaaend-beta.json.checkver.githubis rewritten by Scoop to/releases/latest, which only ever returns the stable release, and the default version regex drops the-betasuffix.Testing
bin/formatjson.ps1: no changes in content (output is byte-identical once CRLF is normalised).bin/checkver.ps1 axolotl-launcher-beta -ThrowError→axolotl-launcher-beta: 1.10.0-beta.5bin/checkver.ps1 axolotl-launcher-beta -Update→ resolves1.10.0-beta.5and leaves the manifest unchanged, i.e.autoupdatereproduces the current URL and never picks up the stable release.bin/checkurls.ps1 axolotl-launcher-beta→ OKbin/checkhashes.ps1 axolotl-launcher-beta→axolotl-launcher-beta: OKCloses #1833