Skip to content

Refactor "between" Value UI into the Date & Time Resolver Family - #323

Open
Sendipad wants to merge 3 commits into
developfrom
refactor-between-value-ui-date-time-resolver-11887870614556050011
Open

Sendipad wants to merge 3 commits into
developfrom
refactor-between-value-ui-date-time-resolver-11887870614556050011

Conversation

@Sendipad

Copy link
Copy Markdown
Owner

Refactored the FlexiRule 'between' operator behavior so that range value representation and UI editing belong to the Date & Time Resolver family (operation: 'between') through DateTimeBetweenConfig.vue with fieldtype-aware 'From' and 'To' controls. Removed duplicated 'Between' UI branching and state handling from Query Records (FilterGroup.vue) and Condition Action Type (SimpleCondition.vue), strictly preserving the existing '[val1, val2]' filter serialization payload contract and backend query semantics.


PR created automatically by Jules for task 11887870614556050011 started by @Sendipad

- Move "between" operator UI ownership into Date & Time Resolver family
- Create DateTimeBetweenConfig.vue with fieldtype-aware "From" and "To" value editors
- Refactor FilterGroup.vue and SimpleCondition.vue to delegate range editing to FlexValueControl
- Preserve [val1, val2] filter value payload serialization and backend QueryRecordsHandler filter contract
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

- Move "between" operator UI ownership into Date & Time Resolver family
- Create DateTimeBetweenConfig.vue with fieldtype-aware "From" and "To" value editors
- Refactor FilterGroup.vue and SimpleCondition.vue to delegate range editing to FlexValueControl
- Preserve [val1, val2] filter value payload serialization and backend QueryRecordsHandler filter contract
- Move "between" operator UI ownership into Date & Time Resolver family
- Create DateTimeBetweenConfig.vue with fieldtype-aware "From" and "To" value editors
- Refactor FilterGroup.vue and SimpleCondition.vue to delegate range editing to FlexValueControl
- Preserve [val1, val2] filter value payload serialization and backend QueryRecordsHandler filter contract

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

1 participant