Repository navigation
Conversation
VargaJoe
marked this pull request as ready for review
November 5, 2026 17:42
VargaJoe
merged commit Nov 5, 2026
81aca15
into
feature/sn-auth-package-extraimprovements
1 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Late authentication responses could restore a signed-out identity, clear a newer session, or leave AdminUI on a blank/loading screen. This follow-up to merged #1655 fixes those paths across IdentityServer, SNAuth and Local authentication.
The existing bare-root repository restoration policy is preserved. Explicit external selection persists its authentication mode. No new container configuration is required.
Deploy the upgraded SNAuth server from SenseNet/sn-auth#14 BEFORE deploying this client. Server14 is merged; its published image was used in the local acceptance. New clients reject older unbound SNAuth callbacks; the upgraded server still supports legacy clients. This PR does not publish a package version or deploy a remote server.
Validation of latest change ae03d4c:
The earlier full-monorepo preview workflow failed in unchanged sn-pickers-react type/dependency inputs (missing @material-ui/lab TreeItem/TreeView); no picker, dependency-manifest, lockfile or workflow change is included here. The Docker workflow builds the AdminUI directly from source aliases. See apps/sensenet/AUTHENTICATION-TESTING.md for acceptance cases.
Local acceptance is complete for the covered cases. Merge and remote deployment remain owner-controlled; verify the target SNAuth runtime is upgraded before the new AdminUI image is rolled out.