Repository navigation
Conversation
VargaJoe
marked this pull request as ready for review
November 4, 2026 20:41
VargaJoe
merged commit Nov 4, 2026
de90629
into
feature/sn-auth-package-extraimprovements
2 of 6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the AdminUI New content form submits only
Name, the repository normalizes that value before an emptyDisplayNamefalls back to it. The displayed title can therefore lose the original accents, casing or non-Latin characters. This also occurs with the existing invalid-character replacement; the optional normalization in SenseNet/sensenet#2248 makes it more visible.Change
Nameinto the create payload'sDisplayNamewhenDisplayNameis missing, empty ornull, andNameis present.DisplayNamevalues exactly, including Unicode and whitespace.With name normalization enabled, a Name-only input such as
árvízTŰRŐ tükörfúrógép 鳥山明 japán és 你好produces:Name:arvizturo-tukorfurogep-niaoshanming-japan-es-nihaoDisplayName:árvízTŰRŐ tükörfúrógép 鳥山明 japán és 你好Scope and compatibility
This changes only the AdminUI new-content submission. Existing content, edit/rename behavior, repository naming providers and server-side validation are unchanged. No configuration switch or data migration is added.
DisplayName-only distinction: the existing DisplayName-only API behavior is preserved and tested. This PR does not make the Name input optional in the AdminUI, so it does not yet implement a DisplayName-only user-interface flow.
Base:
feature/sn-auth-package-extraimprovementsatb5a3545f. Fix commit:2cd2fe26.Validation
Existing base-branch failures
aria-descriptionconsole warning; the same test also fails with the unmodified base.Manual check
Using an AdminUI built from this branch, create a Folder with the multilingual Name above and leave DisplayName blank. Verify that Name is normalized while DisplayName retains the original text. Repeat under a separate parent with an explicit, different Unicode DisplayName and verify that it remains unchanged.