Skip to content

Modernize AdminUI repository selection and remembered connections - #1661

Merged
VargaJoe merged 1 commit into
feature/sn-auth-package-extraimprovementsfrom
codex/adminui-repository-chooser
Nov 10, 2026
Merged

VargaJoe merged 1 commit into
feature/sn-auth-package-extraimprovementsfrom
codex/adminui-repository-chooser

Conversation

@VargaJoe

@VargaJoe VargaJoe commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

AdminUI's repository chooser still showed an obsolete demo action and a generic welcome, while remembered repositories appeared as bare URLs. Replace it with a compact URL + Continue form and a manageable list of remembered connections.

  • Show every pinned connection and the six most recently used unpinned connections, with Show all / Show fewer and no duplicates.
  • Add browser-local display names, pin/unpin, and Remove from this list with Undo. Keep the exact repository URL visible.
  • Store connection metadata separately from authentication sessions. Import existing SNAuth history once; removing a list entry does not clear credentials or sign the user out, and logout does not erase connection history.
  • Remember successful openings across SNAuth, IdentityServer and Local authentication. Token renewal preserves the connection timestamp. Connection discovery errors retain the address for editing and retry.
  • Remove the demo/welcome/helper copy, add English/Hungarian labels, and preserve keyboard focus and narrow layouts.

Existing repository restoration, authentication routing and callback policy are preserved.

Validation at 20a079c:

  • 154/154 focused chooser, storage, provider and authentication regression tests passed across 15 suites.
  • Actual isolated Chrome against the local app passed selection-list actions, rename, removal/Undo, reload persistence, cross-tab updates, URL validation and retained failure input. Layouts at 320, 390, 736 and 1024 px had no horizontal overflow or page errors. The network-failure case used an aborted request; this was not new live identity-provider acceptance.
  • SNAuth and IdentityServer production webpack builds passed with existing asset-size warnings.
  • Scoped ESLint had no errors; three pre-existing SNAuth hook warnings remain. Formatting, diff checks and commit hooks passed.
  • Independent code review found and fixed a malformed-scheme URL validation issue; final review reports no blockers and independently passed 55 targeted tests.

No merge or deployment is included.

@VargaJoe

VargaJoe commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

Independent Codex code review of 20a079c against 81aca15: no remaining merge-blocking findings. The malformed-scheme URL validation issue found during review is fixed and regression-tested. Reviewed connection migration/removal and credential isolation, provider timestamps and failure recovery, list behavior, localization and keyboard focus. Independent targeted rerun: 55/55 passed.

Code-review verdict: GO for this change. This is separate from colleagues' approval and the full CI result.

Validation: 154/154 focused tests, both SNAuth/IdentityServer production builds, and actual isolated Chrome chooser interactions/reload/cross-tab/layout checks passed. The browser network-failure case was simulated; no new live IdP acceptance is claimed.

Full-repository CI is not green: https://github.com/SenseNet/sn-client/actions/runs/42254185965 . Both jobs fail at yarn build before lint/AdminUI build, in unchanged packages/sn-pickers-react: unused React in context/selection.tsx, missing @material-ui/lab/TreeItem and TreeView in picker-advanced.tsx, and implicit-any parameters there. This PR changes no picker sources, dependency manifests, lockfile or workflow. The PR preview workflow is still running.

Merge remains owner-controlled.

@VargaJoe
VargaJoe merged commit 2573218 into feature/sn-auth-package-extraimprovements Nov 10, 2026
1 of 4 checks passed
@VargaJoe
VargaJoe deleted the codex/adminui-repository-chooser branch November 10, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant