Repository navigation
Conversation
|
Independent Codex code review of 20a079c against 81aca15: no remaining merge-blocking findings. The malformed-scheme URL validation issue found during review is fixed and regression-tested. Reviewed connection migration/removal and credential isolation, provider timestamps and failure recovery, list behavior, localization and keyboard focus. Independent targeted rerun: 55/55 passed. Code-review verdict: GO for this change. This is separate from colleagues' approval and the full CI result. Validation: 154/154 focused tests, both SNAuth/IdentityServer production builds, and actual isolated Chrome chooser interactions/reload/cross-tab/layout checks passed. The browser network-failure case was simulated; no new live IdP acceptance is claimed. Full-repository CI is not green: https://github.com/SenseNet/sn-client/actions/runs/42254185965 . Both jobs fail at yarn build before lint/AdminUI build, in unchanged packages/sn-pickers-react: unused React in context/selection.tsx, missing @material-ui/lab/TreeItem and TreeView in picker-advanced.tsx, and implicit-any parameters there. This PR changes no picker sources, dependency manifests, lockfile or workflow. The PR preview workflow is still running. Merge remains owner-controlled. |
2573218
into
feature/sn-auth-package-extraimprovements
AdminUI's repository chooser still showed an obsolete demo action and a generic welcome, while remembered repositories appeared as bare URLs. Replace it with a compact URL + Continue form and a manageable list of remembered connections.
Existing repository restoration, authentication routing and callback policy are preserved.
Validation at 20a079c:
No merge or deployment is included.