Repository navigation
Conversation
serial_write is the one serial endpoint the MCP server does not expose: reset, monitor, output, recover and release are all there. So an MCP-driven client can reboot a board and read what it says, and has no way to reply -- which rules out every prompt-driven flow the endpoint was added for. Not a safety exclusion: flash, ota, gpio_set and serial_reset are all exposed already. The description points at serial_output for the reply rather than implying the call returns it, since the recorder is what captures it.
moellere
force-pushed
the
mcp-serial-write
branch
from
October 17, 2026 16:56
e5ffb03 to
c73808b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #18, which I closed as superseded — your
/api/serial/writeis the better implementation, and this is the one piece of it that is missing.serial_writeis the only serial endpoint the MCP server does not expose:So an MCP-driven client can reboot a board and read what it says, and has no way to reply — which rules out every prompt-driven flow the endpoint was added for: answering a console prompt, driving a firmware CLI, pushing provisioning keys.
Not a safety exclusion —
flash,ota,gpio_setandserial_resetare all exposed already.The description points elsewhere for the reply
Worded so a model does not expect the reply in the return value:
That is the part an agent gets wrong unprompted. It is the same assumption that led me to couple write and read in #18, before
_start_recorderexisted — so it seemed worth spending a sentence on.Verified against a real bench
Driven over stdio against a Pi running current
main(I upgraded it for this), with an ESP32-S3 on SLOT29:One SPECS row, no other changes. Nothing in
pytest/asserts the tool list andmanifest.jsondoes not enumerate tools, so there is nothing else to keep in step.