implement v3 - #26
Merged
Merged
Conversation
- Updated `serialSetFlowControl`, `serialSetParity`, and `serialSetStopBits` functions to accept typed enums instead of integers for better type safety. - Introduced `serialWaitForDrain` function to ensure all output data is transmitted before proceeding. - Modified `serialWrite` function to accept a `SerialTimeoutConfig` structure instead of separate timeout parameters. - Updated unit tests and integration tests to reflect changes in function signatures and ensure proper handling of timeout configurations. - Added new test cases for `serialWaitForDrain` and refactored existing tests to use the new configurations. - Ensured all relevant files include necessary headers for the new implementations.
Katze719
added
enhancement
Katze719
changed the title
Mqxx
requested changes
Sep 8, 2026
Co-authored-by: Mqx <62719703+Mqxx@users.noreply.github.com>
Mqxx
approved these changes
Sep 9, 2026
Mqxx
requested changes
Sep 9, 2026
Mqxx
approved these changes
Sep 9, 2026
Mqxx
requested changes
Sep 9, 2026
Mqxx
requested changes
Sep 10, 2026
Mqxx
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serialSetFlowControl,serialSetParity, andserialSetStopBitsfunctions to accept typed enums instead of integers for better type safety.serialWaitForDrainfunction to ensure all output data is transmitted before proceeding.serialWritefunction to accept aSerialTimeoutConfigstructure instead of separate timeout parameters.serialWaitForDrainand refactored existing tests to use the new configurations.