Repository navigation
Validate the release tag before publishing the gem - #110
Merged
Merged
Conversation
The release workflow now fails before it publishes the gem in these cases: - The tagged commit is not on main. - The tag is not v followed by Oktakit::VERSION. Without this check, a wrong tag published the gem at the version in Oktakit::VERSION.
ScottifyShopson
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The release workflow from #108 publishes the gem for every
vX.Y.Ztag push. It does not check the tag first. These problems can occur:Oktakit::VERSIONpublishes the version inOktakit::VERSION. For example, av1.1.1tag on a commit with version 1.1.0 publishes 1.1.0.mainalso publishes a gem.Changes
Validate release tagstep to therelease_gemjob, before the step that publishes the gem. The step fails the job in these cases:origin/main.vfollowed byOktakit::VERSION.fetch-depth: 0), so that the step can compare the commit withorigin/main.The checks are the same as the checks in #106.