Repository navigation
Fix the remaining RuboCop offenses - #115
Merged
Merged
Conversation
Bundler runs every bundle command, and Gemfile.lock pins its version. The gemspec dependency adds nothing, and it violates Gemspec/DevelopmentDependencies.
The directives disable Metrics/LineLength, which RuboCop renamed to Layout/LineLength. The rubocop-shopify configuration disables Layout/LineLength, so the directives have no effect.
rubocop-shopify enforces the self_class style for Style/ClassMethodsDefinitions. This removes the last entry from .rubocop_todo.yml, so the todo file is deleted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#114 added
.rubocop_todo.ymlfor 5 offenses that RuboCop does not autocorrect. The todo file excludes whole files from these cops, so new offenses in those files also pass without notice.Changes
spec.add_development_dependency('bundler')from the gemspec (Gemspec/DevelopmentDependencies). Bundler runs everybundlecommand, andGemfile.lockpins its version.Metrics/LineLengthdirectives fromspec/client/apps_spec.rb(Lint/RedundantCopDisableDirective). RuboCop renamed the cop toLayout/LineLength, and the rubocop-shopify configuration disables it, so the directives have no effect.Oktakit.new,Oktakit::Error.from_responseandOktakit::Error.errorinsideclass << selfblocks (Style/ClassMethodsDefinitions). The methods stay public class methods with the same behavior..rubocop_todo.ymland theinherit_fromline in.rubocop.yml, because no offenses remain.