Skip to content

Increased the Agent max loops count and fixed failing agent health checks - #509

Open
satti-hari-krishna-reddy wants to merge 18 commits into
Shuffle:mainfrom
satti-hari-krishna-reddy:fresh
Open

satti-hari-krishna-reddy wants to merge 18 commits into
Shuffle:mainfrom
satti-hari-krishna-reddy:fresh

Conversation

@satti-hari-krishna-reddy

Copy link
Copy Markdown
Collaborator

No description provided.

@frikky frikky left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify the decision output controller.

I doubt this will fix anything, as it does not change the actual output format we are expecting.

Comment thread ai.go Outdated
IncludeUsage: true,
}

if chatCompletion.ResponseFormat == nil {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work for all models? Do we have a fallback if a model fails here?

Also, an array does not fit into "json" and "json_object". Is this taken into account?

If we return [{"decision": "here"}], then that does NOT fit with the "json" or "json_object" return mechanism, as that is an array, which LLMs don't support.

So it would require {"decisions": [{"decision": "here"}]}

Comment thread ai.go Outdated

return "", errors.New(fmt.Sprintf("Request from org %s with model '%s' exceeds the maximum number of tokens. %s", org, currentModel, err))
}
// Commented out the potential fix for now as we don't know what the actual reason that's causing "timeout awaiting response headers"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the HTTP request.

The context of the HTTP request itself is set to be too short. Or the third party provider kills the request.

AKA Transport timeout requires manual HTTP config, as you are doing here.

@satti-hari-krishna-reddy satti-hari-krishna-reddy changed the title Enforce Json response format by adding ResponseFormat field to AiCallInfo and update RunAiQuery to handle response format Increased the Agent max loops count and fixed failing agent health checks Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants