Repository navigation
fix(ui): Make office canvas responsive - remove fixed size, add aspect-ratio and 98% width - #6
Merged
Conversation
## Summary
Make the main office canvas responsive and prevent clipping.
## Changes
**File:** `ui/index.html`
1. **CSS (L206)**
- Before: `canvas { display: block; image-rendering: pixelated; image-rendering: crisp-edges; }`
- After: `canvas { display: block; image-rendering: pixelated; image-rendering: crisp-edges; aspect-ratio: 200 / 129; width: 98%; }`
2. **HTML (L461)**
- Before: `<canvas id="cv" width="400" height="258"></canvas>`
- After: `<canvas id="cv"></canvas>`
```diff
-canvas { display: block; image-rendering: pixelated; image-rendering: crisp-edges; }
+canvas { display: block; image-rendering: pixelated; image-rendering: crisp-edges; aspect-ratio: 200 / 129; width: 98%; }
-<canvas id="cv" width="400" height="258"></canvas>
+<canvas id="cv"></canvas>
```
## Why
- Fixed 400x258 attributes caused overflow/clipping inside `.stage` on smaller viewports
- `width: 98%` makes it fit parent with margin
- `aspect-ratio: 200/129` preserves original office ratio (400/258)
- `pixelated / crisp-edges` keeps pixel art sharp
## How to test
1. Run `apollo-office`
2. Resize browser window
3. Verify canvas scales, keeps ratio, stays sharp, no overflow
---
**AI Disclosure:** Code changes authored manually. AI was only used to format this PR description.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 50 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
|
Thanks for the fix, @Prin-Ing! Merged and shipped in v0.8.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the main office canvas responsive and prevent clipping.
Changes
File:
ui/index.htmlCSS (L206)
canvas { display: block; image-rendering: pixelated; image-rendering: crisp-edges; }canvas { display: block; image-rendering: pixelated; image-rendering: crisp-edges; aspect-ratio: 200 / 129; width: 98%; }HTML (L461)
<canvas id="cv" width="400" height="258"></canvas><canvas id="cv"></canvas>Why
.stageon smaller viewportswidth: 98%makes it fit parent with marginaspect-ratio: 200/129preserves original office ratio (400/258)pixelated / crisp-edgeskeeps pixel art sharpHow to test
apollo-officeAI Disclosure: Code changes authored manually. AI was only used to format this PR description.