Fix phone shutdown and recursive push registration - #350
Open
AnkushMalaker wants to merge 13 commits into
Open
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stopping phone capture could send media after the stop control while waiting for acknowledgement, producing a protocol error after audio was saved. Stop now disables frame sending immediately and stops the native microphone before asking Chronicle to finalize. The iOS push-token listener now passes its supplied native token into Expo token registration, removing the request/listener recursion that repeatedly registered the device.
This branch combines the shipped Build 86 phone changes with the backend WebSocket initialization fix and its TestFlight release gate. It preserves the direct live capture path without reconnect buffering.
Validation: both new reproductions failed before the fixes and pass afterwards. The real streaming hook tests cover a native callback during delayed stop and cleanup after native/backend stop failures; the real socket test waits for stop acknowledgement. The push listener test reproduces native token callbacks generated by token requests. All phone diagnostics/self-test/metadata, push, wearable, theme, TypeScript checks and 44 backend audio release tests pass. iOS compilation and native Swift tests run in the TestFlight workflow. Autolinking passes with an existing duplicate Expo log-box warning.
The historical 19-second stop delay is not independently attributed to the push loop; on-device timing and absence of the post-stop error remain installation acceptance checks.