Skip to content

MS-1513 Add another log archive password fallback when project ID not available - #1868

Merged
luhmirin-s merged 1 commit into
mainfrom
feature/MS-1513-zip-password-fix
Oct 19, 2026
Merged

luhmirin-s merged 1 commit into
mainfrom
feature/MS-1513-zip-password-fix

Conversation

@luhmirin-s

Copy link
Copy Markdown
Contributor

JIRA ticket
Will be released in: 2027.1.0

Root cause analysis (for bugfixes only)

First known affected version: 2025.1.0

  • Creating log archive requires a non-blank password string.
  • We used either settings password from config or project ID.
  • Before logging in both are not available.

Notable changes

  • Added another fallback to device ID in for pre-login extraction.
  • IMO, it is fairly safe to use device ID since before login logs do not have any project details.

Testing guidance

  • Open SID without authentication.
  • Press 5 times on the logo.
  • Extract logs.

Additional work checklist

  • Effect on other features and security has been considered
  • Design document marked as "In development" (if applicable)
  • External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
  • Test cases in Testiny are up to date (or ticket created)
  • Other teams notified about the changes (if applicable)

@luhmirin-s
luhmirin-s requested review from a team, BurningAXE, TristramN, alex-vt, alexandr-simprints, meladRaouf and ybourgery and removed request for a team October 19, 2026 12:10
@cla-bot cla-bot Bot added the ... label Oct 19, 2026
@luhmirin-s
luhmirin-s requested a lite review from Copilot October 19, 2026 12:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Add test coverage for whitespace-only settings passwords and project IDs falling back to the device ID.

1 open issue
What changed in this PR

Adds a device ID fallback for log archive passwords when settings and project ID are unavailable, enabling pre-login log extraction.

Changes:

  • Selects the first non-blank value from settings password, project ID, or device ID.
  • Adds archive password and fallback coverage tests.
File Summary
feature/​troubleshooting/​src/​test/​java/​com/​simprints/​feature/​troubleshooting/​overview/​usecase/​ExportLogsUseCaseTest.kt Verifies archive creation and fallback passwords.
feature/​troubleshooting/​src/​main/​java/​com/​simprints/​feature/​troubleshooting/​overview/​usecase/​ExportLogsUseCase.kt Implements non-blank password fallback logic.

Review effort: Lite

@sonarqubecloud

Copy link
Copy Markdown

@luhmirin-s
luhmirin-s merged commit 923c7a5 into main Oct 19, 2026
14 checks passed
@luhmirin-s
luhmirin-s deleted the feature/MS-1513-zip-password-fix branch October 19, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants