Repository navigation
MS-1513 Add another log archive password fallback when project ID not available - #1868
Merged
Merged
Conversation
luhmirin-s
requested review from
a team,
BurningAXE,
TristramN,
alex-vt,
alexandr-simprints,
meladRaouf and
ybourgery
and removed request for
a team
October 19, 2026 12:10
luhmirin-s
force-pushed
the
feature/MS-1513-zip-password-fix
branch
from
October 19, 2026 12:11
23eac6c to
0e1ac23
Compare
meladRaouf
approved these changes
Oct 19, 2026
There was a problem hiding this comment.
🟡 Changes recommended
Add test coverage for whitespace-only settings passwords and project IDs falling back to the device ID.
1 open issue
What changed in this PR
Adds a device ID fallback for log archive passwords when settings and project ID are unavailable, enabling pre-login log extraction.
Changes:
- Selects the first non-blank value from settings password, project ID, or device ID.
- Adds archive password and fallback coverage tests.
| File | Summary |
|---|---|
feature/troubleshooting/src/test/java/com/simprints/feature/troubleshooting/overview/usecase/ExportLogsUseCaseTest.kt |
Verifies archive creation and fallback passwords. |
feature/troubleshooting/src/main/java/com/simprints/feature/troubleshooting/overview/usecase/ExportLogsUseCase.kt |
Implements non-blank password fallback logic. |
Review effort: Lite
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




JIRA ticket
Will be released in: 2027.1.0
Root cause analysis (for bugfixes only)
First known affected version: 2025.1.0
Notable changes
Testing guidance
Additional work checklist