Repository navigation
Slack tools stop asking the agent for the token - #11
Merged
Merged
Conversation
The published Slack Web API specs declare the credential as an ordinary `token` input on every operation. Each generated tool therefore required the caller to supply a token and sent it in the query or form body, which Slack rejects for current apps, so calls failed with a schema error or invalid_auth even when the connection held a valid credential. A slack-web-api spec format adapter, detected from the apis.guru and slackapi spec URLs, drops the `token` parameter and form field when the spec is loaded. The connection's credential, sent as an Authorization header, is then the only one. Existing integrations pick it up on refresh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What users saw
Tools from a Slack Web API integration (added from the apis.guru Slack spec) asked the agent for a
tokenargument on every call. Agents do not have the token, so calls either failed validation (Instance does not have required property "token") or reached Slack with a wrong token and came backinvalid_auth, even though the integration's connection held a valid credential.Cause
The published Slack specs predate header auth. They declare the credential as an ordinary
tokeninput on all operations: a query or header parameter on 155 operations and a form field on 15 (required on 11). Executor turns those into tool arguments, so the caller is asked for the credential the connection is supposed to supply.Change
slack-web-apispec format adapter (@executor-js/plugin-openapi/providers/slack), detected from the apis.guruslack.comandslackapi/slack-api-specsURLs. It removes thetokenparameter and form field (and itsrequiredentry) when the spec is loaded. The connection's credential, sent as anAuthorizationheader, becomes the only one.Not changed
The spec's OAuth endpoints are still Slack's legacy v1 ones. Connections already made keep working; that is separate from this fix.