Repository navigation
feat(mcp): raise the per-tool-call active-work deadline from 60 seconds to one hour - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A single long upstream tool call was cut off at 60 seconds. One hour still bounds a hung upstream.
What
MCP_ACTIVE_WORK_TIMEOUT_MSinpackages/plugins/mcp/src/sdk/invoke.ts: 60_000 to 3_600_000.invoke.test.tsasserts the literal 3_600_000, proves the default deadline fires at exactly one hour, and still proves the deadline pauses during elicitation (fake timers).e2e/selfhost/mcp-elicitation-deadline.test.ts: comment no longer claims the 65 s sleep crosses the production deadline.@executor-js/plugin-mcp.