Repository navigation
feat(sdk): tell internal hosts which account is calling - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes for users
A Worker exposed as an internal integration (a
*.internalhost served over a service binding) can now tell who is calling. Every request Executor routes to it carries the acting account inx-executor-account-id. That lets an internal integration restrict tools to some accounts, for example admin-only tools, which org-wide tool policies cannot express.How
HostedHttpClientOptions.internalCaller:routeInternalHostssetsx-executor-account-idon requests to a configured internal host. It always removes a value the request already carried, so a connection header cannot spoof it, and it never adds the header for other hosts.makeScopedExecutorpasses itsaccountId. The platform view has no subject, so its internal requests carry no caller.Tests
hosted-http-client.test.ts: the binding sees the configured caller instead of a spoofed value, sees no header when no caller is configured, and an external host never receives it.packages/core/sdk(970) andpackages/core/api(132) pass.