Matter Sensor/Thermostat: Handle invalid unit conversions #3116
Open
hcarter-775 wants to merge 6 commits into
Open
Matter Sensor/Thermostat: Handle invalid unit conversions #3116hcarter-775 wants to merge 6 commits into
hcarter-775 wants to merge 6 commits into
Conversation
hcarter-775
force-pushed
the
chore/handle-invalid-unit-conversions
branch
from
July 13, 2026 18:03
b45f3a5 to
0530456
Compare
|
Invitation URL: |
|
matter-sensor_coverage.xml
matter-thermostat_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 42f6792 |
hcarter-775
force-pushed
the
chore/handle-invalid-unit-conversions
branch
from
July 16, 2026 16:47
1ee42b7 to
bb91db4
Compare
tpmanley
reviewed
Jul 16, 2026
|
|
||
| if not reporting_unit then | ||
| reporting_unit = fields.unit_default[capability_name] | ||
| device:set_field(capability_name.."_unit", reporting_unit, {persist = true}) |
Contributor
There was a problem hiding this comment.
Why is this removed but there is still code that reads the field?
Contributor
Author
There was a problem hiding this comment.
we set the field elsewhere, in the measurement unit read handler. There is no need to set a field to a default. If the unit is unavailable in the field, we just use the default.
Contributor
|
Can some tests be added to test the invalid inputs/conversions? |
Contributor
Author
Added a few! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Handle invalid unit conversions by checking for valid molecular weights and valid input values. For Matter Sensor, update handling to include a greater number of conversions and more invalid data handling, akin to what is in Matter Thermostat.
Earlier today, a massive number of coroutine errors were generated related to improper number to string arithmetic operations. This adds greater checks to ensure that does not happen. Also, Matter Sensor was fairly behind and so was updated more generally to match the logic of Matter Thermostat.