Repository navigation
Remove unused helpers with no callers - #181
Merged
Merged
Conversation
Repo-wide search finds each removed symbol only at its definition. Live callers, including providerServicesForEnv, resolveSessionAccess, and the workflow node executors, stay in place. Co-authored-by: Jonathan Beckman <jonathantbeckman@gmail.com>
jonbeckman
marked this pull request as ready for review
November 8, 2026 09:28
Contributor
TegamiThis repository uses Tegami to manage releases. When your changes affect published packages, add a changelog file under Create a changelog → · Changelog format No changelogs yetThis PR has no pending changelog files. If your changes require a release, add a changelog before merging. Run Managed by Tegami. |
Contributor
🟢 e2e solzero-core: 15 passed, 17 left out by filters2 agent steps · 2 replayed from cache Change 15 files changed since 17 tests left out by filters
All 15 tests in 8 files
e2e 0.21.3 · 2m 7s · local-cloudflare · run artifacts |
Co-authored-by: Jonathan Beckman <jonathantbeckman@gmail.com>
Co-authored-by: Jonathan Beckman <jonathantbeckman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes helpers that have no callers in this repository. A search of the tree finds each symbol only at its definition. The live paths they sat next to stay in place:
providerServicesForEnv,resolveSessionAccess,failSetup,toRuntimeActivityRow, and the workflow node executors.Removed:
getAppStageMetadataFromStr,getAppStageMetadataSync, and their private helpers). Browser code reads Vite env throughgetAppStageMetadata()inapps/web/src/lib/runtime-config.ts. Workers readgetStageMetadataSync.describeAgentRuntimeModelCompatibilityand its description table.parseCustomMcpServerId,encodeSessionToolQueryValue, andappendSessionToolsToSearchParams.LiveProviderLayer,MockProviderLayer, andproviderLayerForEnv. Call sites useproviderServicesForEnv.controlPlaneDialectForEngine.getGitHubAppConfigOrThrow.buildSetupResponse.failSetupstill builds the setup URL.resolveSessionAccessPromise. Routes callresolveSessionAccess.toSandboxActivityRow.toRuntimeActivityRowstill maps stored rows.isVisibleModelForUserandtoEditableCustomProviderSettings.isWorkflowHttpNodeType,isWorkflowNotificationNodeType,isWorkflowSessionNodeType,isWorkflowStorageNodeType, andgetRegisteredWorkflowNodeAdapterCategories.release:none: no user, administrator, or operator behavior changes. The symbols were unreferenced.Validation
nub run typechecknub run lintnub run formatnub run testwas not run. These symbols have no callers, so no flow changes.Checklist
.tegami/release entry, or explained why this pull request usesrelease:none.nub run config:check,nub run typecheck,nub run lint,nub run format, andnub run test. (config:checkandtestwere not run; see Validation.)THIRD_PARTY_NOTICES.mdfor new third-party code or separately licensed assets. (No new third-party code.)