Repository navigation
Remove session socket debug traces - #183
Merged
Merged
Conversation
These console.log calls record connection chatter and the prompt text. They do not change socket state, reconnects, or what the page renders. console.error stays on the failure paths. Co-authored-by: Jonathan Beckman <jonathantbeckman@gmail.com>
jonbeckman
marked this pull request as ready for review
November 8, 2026 09:28
Contributor
TegamiThis repository uses Tegami to manage releases. When your changes affect published packages, add a changelog file under Create a changelog → · Changelog format No changelogs yetThis PR has no pending changelog files. If your changes require a release, add a changelog before merging. Run Managed by Tegami. |
Contributor
🟢 e2e solzero-core: 4 passed, 27 left out by filters1 agent step · 1 replayed from cache Change 1 file changed since 27 tests left out by filters
All 4 tests in 3 files
e2e 0.21.3 · 1m 17s · local-cloudflare · run artifacts |
Co-authored-by: Jonathan Beckman <jonathantbeckman@gmail.com>
Co-authored-by: Jonathan Beckman <jonathantbeckman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
console.logtraces from the session WebSocket hook. They recorded subscribe, connect, close, and reconnect chatter, and they printed the prompt text. Connection state, reconnect timing, and the rendered session do not use those logs.console.errorstays on the failure paths: token fetch, parse errors, a socket that is not open, and reconnect exhaustion.release:none: no user-visible session behavior changes.Validation
nub run typechecknub run lintnub run formatnub run testwas not run. The hook's state updates are unchanged, and no end-to-end step asserts on browser console output.Checklist
.tegami/release entry, or explained why this pull request usesrelease:none.nub run config:check,nub run typecheck,nub run lint,nub run format, andnub run test. (config:checkandtestwere not run; see Validation.)THIRD_PARTY_NOTICES.mdfor new third-party code or separately licensed assets. (No new third-party code.)