Repository navigation
Enable Effect lint rules the service code already follows - #184
Merged
Merged
Conversation
use-console-service, avoid-direct-tag-checks, throw-in-effect-gen, prefer-duration-constructors, and avoid-ts-ignore now error on the Effect service paths. The current tree already satisfies them. Co-authored-by: Jonathan Beckman <jonathantbeckman@gmail.com>
jonbeckman
marked this pull request as ready for review
November 8, 2026 09:28
Contributor
🟢 e2e solzero-core: no tests selected, 30 left out by filtersChange 1 file changed since 30 tests left out by filters
e2e 0.21.3 · 6ms · local-cloudflare · run artifacts |
Contributor
TegamiThis repository uses Tegami to manage releases. When your changes affect published packages, add a changelog file under Create a changelog → · Changelog format No changelogs yetThis PR has no pending changelog files. If your changes require a release, add a changelog before merging. Run Managed by Tegami. |
Co-authored-by: Jonathan Beckman <jonathantbeckman@gmail.com>
Co-authored-by: Jonathan Beckman <jonathantbeckman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Turns on five
@mpsuesser/oxlint-plugin-effectrules for the existing Effect service paths:effect/use-console-serviceeffect/avoid-direct-tag-checkseffect/throw-in-effect-geneffect/prefer-duration-constructorseffect/avoid-ts-ignorenub run lintis clean with these rules set to error. They match the Effect skill: structured logs, tag matching, typed failures, duration constructors, and nots-ignore.effect/use-clock-serviceis not enabled. It currently reports directDateuse across the service tree, and switching those call sites toClockis a separate migration.release:none: lint configuration only. No runtime change.Validation
nub run lintwith the new rules enablednub run typechecknub run formatnub run testwas not run. No executable behavior changed.Checklist
.tegami/release entry, or explained why this pull request usesrelease:none.nub run config:check,nub run typecheck,nub run lint,nub run format, andnub run test. (config:checkandtestwere not run; see Validation.)THIRD_PARTY_NOTICES.mdfor new third-party code or separately licensed assets. (No new third-party code.)