Repository navigation
Add a heartbeat option for runners that register on demand - #16
Closed
jonbeckman wants to merge 1 commit into
Closed
jonbeckman wants to merge 1 commit into
jonbeckman wants to merge 1 commit into
Conversation
kinhin registers macOS runners only when a matching job is queued, and keeps one Linux runner that is busy during a job and gone for seconds after it. primaries-required never sees an idle macOS runner, so those pools always fell back. A pool's heartbeat names labels of a runner that shows the host is up; while one is online, busy or not, the pool uses its primary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vdh4Z431pzGdWVWoAFNQqc
Contributor
Author
|
Closing this. The fix belongs in the runner host: RabinApps/kinhin#74 adds Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The grokcast pilot showed that the
xcodepool always falls back. The route job logged "no matching primary runner is online". The mayflower report gives the cause: kinhin registers macOS and Xcode runners only after a matching job is queued, so Routact never sees one while it routes. Linux has the same problem in a smaller form. kinhin keeps one warm runner, that runner is busy during a job, and no runner is listed for 18 to 65 seconds after a job and at the hourly warm-pool recycle.A pool can now set
heartbeat. Its value is the labels of a runner that shows only that the host is up. While any online runner has those labels, busy or not, the pool uses its primary, and the autoscaler starts a runner for the queued job.primaries-required, because it does not count idle runners. This is a config error.claim, for the same reason. The route job fails with a config error.Testing
npm run all: lint passes,dist/is rebuilt, and 130 tests pass.Generated by Claude Code