Adapt to minarrow shared_dict feature - #5
Merged
Merged
Conversation
Migrate all CategoricalArray struct literal construction to use the CategoricalArray::new() constructor, which handles both shared_dict and non-shared_dict feature configurations internally. Migrate all .unique_values field accesses to the .unique_values() method form. Replace the manual window_categorical function with CategoricalArray::slice_clone, which preserves the dictionary sharing relationship under shared_dict. Replace the SuperTable struct literal construction with SuperTable::from_batches, which handles the category_managers field that shared_dict adds. Generated with Claude Code (Fable 5.1)
Four multi-line .unique_values accesses were missed by the initial sed pass because the field name appeared on its own line. Generated with Claude Code (Fable 5.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates lightstream to compile correctly when minarrow's
shared_dictandallow_mixed_array_batchesfeatures are enabled.