chore: quiet analyzer noise and await cache/upgrade futures - #488
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (10)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe changes expand analyzer exclusions across project packages and examples. The movie app adopts the default navigation API. Cache and redirect operations now await asynchronous calls. ChangesProject maintenance updates
Estimated code review effort: 2 (Simple) | ~15 minutes Merge Risk: ⚪ Minimal · up to The changes improve analyzer scope, asynchronous error handling, navigation compatibility, and dependency lockfiles without introducing an actionable merge-blocking risk; the PR is merge-ready after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (10 skipped: 10 unsupported.) Full details: Title checkExplanation The title accurately summarizes two primary changes: reducing analyzer noise and awaiting cache and upgrade futures. It does not mention the navigation widget migration, but the title need not cover every change. ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bfc1bd8 to
93233ae
Compare
Exclude generated platform trees from analysis, migrate the movie app off deprecated navigation widgets, and await SharedPreferences and CLI download futures so errors hit the existing try/catch paths.
93233ae to
9602713
Compare
Description
Keeps
dart analyzefrom walking generated platform trees, migrates the movie app off the deprecated navigation widgets, and awaits SharedPreferences / CLI download futures so failures land in the existingtry/catchpaths instead of escaping as unhandled async errors.Also refreshes example and playground lockfiles for the current Flutter/Dart SDK (matcher, meta, test_api, vector_math).
Related Issues
N/A
Type of Change
Test plan
melos analyzeand confirm no new issues from generatedandroid/ios/webtreesfalseon SharedPreferences failure instead of throwingstac upgradefollows a redirect and completes the download