Skip to content

chore: quiet analyzer noise and await cache/upgrade futures - #488

Merged
divyanshub024 merged 1 commit into
mainfrom
dv/analyze-hygiene-and-await-fixes
Sep 1, 2026
Merged

chore: quiet analyzer noise and await cache/upgrade futures#488
divyanshub024 merged 1 commit into
mainfrom
dv/analyze-hygiene-and-await-fixes

Conversation

@divyanshub024

@divyanshub024 divyanshub024 commented Sep 1, 2026

Copy link
Copy Markdown
Member

Description

Keeps dart analyze from walking generated platform trees, migrates the movie app off the deprecated navigation widgets, and awaits SharedPreferences / CLI download futures so failures land in the existing try/catch paths instead of escaping as unhandled async errors.

Also refreshes example and playground lockfiles for the current Flutter/Dart SDK (matcher, meta, test_api, vector_math).

Related Issues

N/A

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code refactor
  • Build configuration change
  • Documentation
  • Chore

Test plan

  • Run melos analyze and confirm no new issues from generated android/ios/web trees
  • Open movie app home screen and confirm the 3-tab bottom nav still switches views
  • Confirm cache save/remove still returns false on SharedPreferences failure instead of throwing
  • (Optional) stac upgrade follows a redirect and completes the download

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: d1a623d0-e8cb-4ce0-83cd-15377e069f88

📥 Commits

Reviewing files that changed from the base of the PR and between 1babaea and bfc1bd8.

⛔ Files ignored due to path filters (3)
  • examples/counter_example/pubspec.lock is excluded by !**/*.lock
  • examples/movie_app/pubspec.lock is excluded by !**/*.lock
  • stac_playground/pubspec.lock is excluded by !**/*.lock
📒 Files selected for processing (10)
  • examples/counter_example/analysis_options.yaml
  • examples/movie_app/analysis_options.yaml
  • examples/movie_app/stac/home_screen.dart
  • packages/stac/analysis_options.yaml
  • packages/stac/lib/src/services/stac_cache_service.dart
  • packages/stac_cli/lib/src/exceptions/build_exception.dart
  • packages/stac_cli/lib/src/services/upgrade_service.dart
  • packages/stac_framework/analysis_options.yaml
  • packages/stac_webview/analysis_options.yaml
  • stac_playground/analysis_options.yaml

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The changes expand analyzer exclusions across project packages and examples. The movie app adopts the default navigation API. Cache and redirect operations now await asynchronous calls. ConversionException uses super-parameter syntax.

Changes

Project maintenance updates

Layer / File(s) Summary
Analyzer exclusion configuration
examples/counter_example/analysis_options.yaml, examples/movie_app/analysis_options.yaml, packages/stac/analysis_options.yaml, packages/stac_framework/analysis_options.yaml, packages/stac_webview/analysis_options.yaml, stac_playground/analysis_options.yaml
Analyzer exclusions now cover build output, platform directories, and generated Freezed files where applicable.
Movie app navigation update
examples/movie_app/stac/home_screen.dart
The movie app replaces the bottom-navigation controller and view with the default navigation controller and navigation view.
Asynchronous operation handling
packages/stac/lib/src/services/stac_cache_service.dart, packages/stac_cli/lib/src/services/upgrade_service.dart
Cache writes, cache removals, and redirected downloads now await asynchronous operations before returning.
Exception constructor syntax
packages/stac_cli/lib/src/exceptions/build_exception.dart
ConversionException uses the super.cause super-parameter.

Estimated code review effort: 2 (Simple) | ~15 minutes

Merge Risk: ⚪ Minimal · up to bfc1b

The changes improve analyzer scope, asynchronous error handling, navigation compatibility, and dependency lockfiles without introducing an actionable merge-blocking risk; the PR is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes two primary changes: reducing analyzer noise and awaiting cache and upgrade futures. It does not mention the navigation widget migration, but the title need not cover e…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (10 skipped: 10 unsupported.)

Full details: Title check

Explanation

The title accurately summarizes two primary changes: reducing analyzer noise and awaiting cache and upgrade futures. It does not mention the navigation widget migration, but the title need not cover every change.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dv/analyze-hygiene-and-await-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@divyanshub024
divyanshub024 force-pushed the dv/analyze-hygiene-and-await-fixes branch from bfc1bd8 to 93233ae Compare September 1, 2026 21:39
Exclude generated platform trees from analysis, migrate the movie
app off deprecated navigation widgets, and await SharedPreferences
and CLI download futures so errors hit the existing try/catch paths.
@divyanshub024
divyanshub024 force-pushed the dv/analyze-hygiene-and-await-fixes branch from 93233ae to 9602713 Compare September 1, 2026 21:41
@divyanshub024
divyanshub024 merged commit d8ec4bd into main Sep 1, 2026
6 checks passed
@divyanshub024
divyanshub024 deleted the dv/analyze-hygiene-and-await-fixes branch September 1, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant