Conversation
Data platform is picking it up.
This was referenced Sep 9, 2026
🛡️ Tirith — 1 warned, 3 passedScanned commit + aws_s3_bucket.analytics create
+ bucket = "demo-tirith-action-analytics-790543352839"
+ force_destroy = false
+ tags = {"Demo":"tirith-action-demo","Name":"tirith-action-demo","Owner":"data-platform"}
+ tags_all = {"Demo":"tirith-action-demo","Name":"tirith-action-demo","Owner":"data-platform"}
… and 23 computed attribute(s), known after applyPlan: 1 to add, 0 to change, 0 to destroy. 5 unchanged.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data platform is picking it up, so the tag
chapter 3 left blank now has a value.
One line. The
Ownerrule passes, the verdict goes green, andApplystops being skipped — the bucketcan ship.
That is the part worth watching. The check that blocked the merge is not a wall around the pipeline; it
is a step inside it, and it clears the moment the thing it objected to is fixed. No ticket, no
exception process, no separate tool to go and look at.
The diff block still shows the bucket being created, now with a real
Owner. The change did not goaway — only the objection to it. Which is the distinction a reviewer actually needs.
Chapter 4 of 5. Based on #18 · Next: #20 — Publish the terraform state after apply