Repository navigation
Conversation
Android and Google Decimeter logs containing QZSS PRN 197, 200 or 201 raised a KeyError in postprocess() because the PRN-to-SVN table only listed PRNs 193-196 and 199. Add the remaining PRNs from IS-QZSS-PNT-004 Table 3.2.1-1, which match the QZSS constellation page for QZS-6 (SVN 7) and QZS-7 (SVN 8). Fixes Stanford-NavLab#183
Member
|
Looks good. I agree that the 197 PRN is confusing since it's not on the current constellation status page, but I don't see the harm in adding it. Do you want to add yourself to the contributors list? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v1.1.1 #191 +/- ##
=======================================
Coverage 99.61% 99.61%
=======================================
Files 27 27
Lines 3899 3899
=======================================
Hits 3884 3884
Misses 15 15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
Thanks! Yes, I'd be glad to. I've pushed a commit adding myself to CONTRIBUTORS.md. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #183
AndroidRawGnss.postprocess()andAndroidDerived2022.postprocess()(also used byAndroidDerived2023) map QZSS PRNs to SVNs throughQZSS_PRN_SVN. That table only has PRNs 193–196 and 199, so a log containing any other QZSS PRN raisesKeyError, as in the issue with PRN 197.This PR adds the missing PRNs from IS-QZSS-PNT-004 Table 3.2.1-1:
The SVNs for QZS-6 and QZS-7 match the QZSS constellation page already cited for this table (https://sys.qzss.go.jp/dod/en/constellation.html). That page lists QZS-6 as operational on PRN 200, so current logs from Asia/Oceania would hit the same error. QZS-5 was lost at launch in December 2025, so PRN 197 in the reporter's log may not come from a real satellite. It is still the PRN the spec assigns, and parsing shouldn't fail on it.
Testing: added
test_qzss_prn_to_svn, which rewrites the QZSS rows of the 2023 Pixel 7 Pro test log to PRN 197 and checks they load with SVN 6. It fails onmainwithKeyError: np.int64(197)and passes with this change.tests/parsers/test_android.pyandtests/parsers/test_google_decimeter.pypass, excepttest_raw_load, which needs an FTP ephemeris download that times out from my machine (same onmain). pylint reports nothing new on the changed files.