Skip to content

Add QZSS PRNs 197, 200 and 201 to QZSS_PRN_SVN - #191

Open
Wahaj18 wants to merge 3 commits into
Stanford-NavLab:v1.1.1from
Wahaj18:fix-183-qzss-prn-197
Open

Wahaj18 wants to merge 3 commits into
Stanford-NavLab:v1.1.1from
Wahaj18:fix-183-qzss-prn-197

Conversation

@Wahaj18

@Wahaj18 Wahaj18 commented Oct 11, 2026

Copy link
Copy Markdown

Fixes #183

AndroidRawGnss.postprocess() and AndroidDerived2022.postprocess() (also used by AndroidDerived2023) map QZSS PRNs to SVNs through QZSS_PRN_SVN. That table only has PRNs 193–196 and 199, so a log containing any other QZSS PRN raises KeyError, as in the issue with PRN 197.

This PR adds the missing PRNs from IS-QZSS-PNT-004 Table 3.2.1-1:

PRN SVN Satellite
197 6 QZS-5
200 7 QZS-6
201 8 QZS-7

The SVNs for QZS-6 and QZS-7 match the QZSS constellation page already cited for this table (https://sys.qzss.go.jp/dod/en/constellation.html). That page lists QZS-6 as operational on PRN 200, so current logs from Asia/Oceania would hit the same error. QZS-5 was lost at launch in December 2025, so PRN 197 in the reporter's log may not come from a real satellite. It is still the PRN the spec assigns, and parsing shouldn't fail on it.

Testing: added test_qzss_prn_to_svn, which rewrites the QZSS rows of the 2023 Pixel 7 Pro test log to PRN 197 and checks they load with SVN 6. It fails on main with KeyError: np.int64(197) and passes with this change. tests/parsers/test_android.py and tests/parsers/test_google_decimeter.py pass, except test_raw_load, which needs an FTP ephemeris download that times out from my machine (same on main). pylint reports nothing new on the changed files.

Android and Google Decimeter logs containing QZSS PRN 197, 200 or 201
raised a KeyError in postprocess() because the PRN-to-SVN table only
listed PRNs 193-196 and 199. Add the remaining PRNs from IS-QZSS-PNT-004
Table 3.2.1-1, which match the QZSS constellation page for QZS-6
(SVN 7) and QZS-7 (SVN 8).

Fixes Stanford-NavLab#183
@betaBison
betaBison changed the base branch from main to v1.1.1 November 4, 2026 05:09
@betaBison

Copy link
Copy Markdown
Member

Looks good. I agree that the 197 PRN is confusing since it's not on the current constellation status page, but I don't see the harm in adding it.

Do you want to add yourself to the contributors list?

@codecov

codecov Bot commented Nov 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.61%. Comparing base (08cbf60) to head (d10e327).

Additional details and impacted files
@@           Coverage Diff           @@
##           v1.1.1     #191   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files          27       27           
  Lines        3899     3899           
=======================================
  Hits         3884     3884           
  Misses         15       15           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Wahaj18

Wahaj18 commented Nov 4, 2026

Copy link
Copy Markdown
Author

Thanks! Yes, I'd be glad to. I've pushed a commit adding myself to CONTRIBUTORS.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QZSS PRN 197 Encountered in real measurements, missing in QZSS PRN-to-SVN mapping

2 participants