Add ILComparisonTool to the solution - #165
Merged
Merged
Conversation
The project sits under test/ and references Hyperbee.Expressions.Compiler, but it was not in the solution, so no solution build ever compiled it and neither did CI. A change to the compiler could break it with nothing reporting that until someone tried to run it. It is IsPackable=false and single-targeted at net9.0, so including it adds a build but cannot reach the published packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/ILComparisonToolwas not listed inHyperbee.Expressions.slnx, so no solution buildever compiled it, and neither did CI. It has a
ProjectReferencetoHyperbee.Expressions.Compiler, so a change there could break it with nothing reporting thebreak until someone tried to run the tool.
Found while verifying that the test suites for #164 really covered everything. The tool does
still build today; this stops it rotting silently.
Safe to include in the solution: it is
IsPackable=falseand single-targeted atnet9.0, soit adds a build but cannot reach the published packages. It contains no tests, so
dotnet teston the solution is unchanged.Verified: solution build now compiles
ILComparisonTool.dll, 0 warnings, 0 errors, and thethree test suites are unaffected.
🤖 Generated with Claude Code