Repository navigation
D2: cvc5 1.1.2 and 1.4.2 both in CI, and --version reads 1.4 - #100
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI ran the test suite only with cvc5 1.1.2, the release Ubuntu 24.04 packages. 1.4 support (#22's
arrays-exp) was checked by hand.cpp-verify --versionalso could not read the version of cvc5 1.4:That is because cvc5 1.1.2 prints
This is cvc5 version 1.1.2, while 1.4.2 printscvc5 1.4.2 [git 282d5e0 on branch HEAD].This is plan item D2, part of exit criterion 9 ("cvc5 1.1.2 and 1.4.x both in CI").
Change
cvc5-Linux-x86_64-static.zip), so each matrix entry names its archive.--versionreads either form of the version line, and names the tested range:The range is two constants in
CppVerifyVersion.h,CVC5OldestTestedVersionandCVC5NewestTestedVersion, beside the Lean pin.Tests
version.testadds a cvc5 that prints its version as 1.4 does, and every case expects the range. Onmainthe new case printsunknownand fails.Each mutant below, applied alone, fails
version.test:cvc5 versionThe 17 tests that require cvc5 pass with cvc5 1.4.2 (the static Linux release) as with 1.1.2.
Docs
Checked
version.testanddocs_coverage.testpass on this branch.cpp-verify --versionprints the real version of both cvc5 binaries, as shown above.