Repository navigation
S8: a smoke test that checks more, and Lean from its GitHub release in CI - #108
Merged
Merged
Conversation
…a failure in the smoke test.
…-lang.org refuses connections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The smoke test gates publishing a release (
cppverify-release.ymlruns it on each unpacked archive) and runs after every CI build. It checked less than it seemed to (plan item S8):--versionwithout looking at it;clang++ -fverify-contracts, but never the incorrect one, so aclang++that skipped verification passed;cpp-verify-X-llvm-PLATFORMwhen--versionnamed no LLVM release, since nothing checked the version it parsed.Now the smoke test checks:
--versionstarts with cpp-verify's version, names the LLVM release, and names the built-in Z3;clang++ -fverify-contractswrites an object for the correct program, and for the incorrect one reportsverification failed: twiceand writes none;The release workflow stops when the LLVM version it parses is empty.
The checks hold for the formats on
mainand for those of #104 and #105:verification failed: twice, a counterexamplex =with or without the old[ssa=x_0] [type=i32]tags, and a JSON model entry namedx.Checked
The script passes on a release build. It fails, at the check meant for each, when a wrapper breaks one property:
--versionwithout its z3 lineerror: --version names no built-in Z3cpp-verifyverifies everythingerror: the incorrect program verifiederror: the incorrect program's counterexample is missingerror: the incorrect program's JSON record is missingclang++compiles the incorrect programerror: clang++ -fverify-contracts compiled the incorrect programclang++without-fverify-contractsset -e)Lean in CI
Since about 04:00 UTC today, every Linux CI job,
main's included, stops at "Report the versions": elan installs the pinned toolchain on first use, fromreleases.lean-lang.org, which refuses TLS connections ([35] SSL connect error, and the same from a machine outside GitHub), so no test runs. The job now installs elan without a toolchain, unpacks the pinned Lean from its GitHub release (leanprover/lean4,lean-4.35.0-linux.tar.zst) into the directory where elan keeps it (~/.elan/toolchains/leanprover--lean4---v4.35.0), and makes it the default.elan defaultdownloads a toolchain it does not find, so a wrong directory fails that step, not a test.