Repository navigation
test: extent_separation.cpp's wrong copy fails at once - #112
Closed
SwayamInSync wants to merge 1 commit into
Closed
SwayamInSync wants to merge 1 commit into
SwayamInSync wants to merge 1 commit into
Conversation
…solver refutes at once.
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extent_separation.cppfailed on #93's macOS runner, a change that touches no verifier code:wrong_copyis the test's negative case: a copy loop that writes the wrong values must fail its invariant. It wrotea[n - 1 - i], a reversed copy, and finding a counterexample to its quantified invariant is a hard search. On a Linux machine, three runs ofwrong_copyalone with--jobs=1took 32.6 s and 41.9 s to fail, and the third endedUnresolved [solver.timeout]after 61.5 s.The loop now writes zeros (
out[i] = 0;). The invariantout[j] == a[j]then fails whereveraholds another value: three runs failed in 1.4 s each, and the whole file takes 0.7 s. The case still shows what it is for: under the separation of extents, a copy that is wrong fails, andcopyverifies.This is the third test of the kind after #106 (
cvc5_memory_limit.cpp,spec_post_unfolded.cpp). Together they unblock the stack #93 to #99, whose assertions jobs fail only oncvc5_memory_limit.cpp, and whose macOS jobs failed on this test.