Repository navigation
T6: run the Verify suite five times every night on Linux and macOS, and name every flaky test - #124
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan item T6 (stability CI), for exit criterion 3 (steady verdicts): nothing measured whether the Verify suite gives the same results run after run, and flaky tests showed up only as red marks on unrelated pull requests (
confirmation_invariants.cppon #105 and #110).With this PR
cppverify-stability.ymlruns every night (04:17 UTC) and on demand:setup.sh, as CI's macOS job);lit -o);cppverify-stability.pycompares the runs and fails the job when a test is notPASS,UNSUPPORTED, orXFAILin some run, naming it with its result in each run, as flaky (results differ) or failing (the same failure every time):(the script on two real runs of two tests and a third with one result changed by hand).
Seeds are not part of it: cpp-verify does not expose the solver's random seed, and a test that checks a counterexample's values would change with it although its verdict does not.
Not tested here
A workflow can be started by hand only once it is on the default branch, so its first run will be after the merge; it reuses the build steps of
cppverify-differential.yml(Linux) and CI's macOS job unchanged.