Repository navigation
Adopt Z3 releases only through a gate in CI; keep 4.13.4 for 0.2 - #135
Open
SwayamInSync wants to merge 10 commits into
Open
SwayamInSync wants to merge 10 commits into
SwayamInSync wants to merge 10 commits into
Conversation
# Conflicts: # docs/ARCHITECTURE.md # website/source/release-notes.rst
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan item D1 (a current Z3, adopted only through the gate) and exit criterion 9. The gate existed as a private script over the sequence benchmark and a 20-file corpus. This makes it a CI job over every Verify test program, runs it for the newest Z3, 5.3.2 (2026-10-25), and records the verdict: 0.2 keeps Z3 4.13.4.
The gate (
clang/utils/cppverify-z3-gate)gate.sh BASE CANDIDATE, given two cpp-verify builds that differ in their Z3:seqbench.py, from the study that chose cpp-verify's sequence encoding): every valid and false claim, in cpp-verify's encoding (NT) and in the plain sequence theory (N), solved by both Z3 binaries. A claim counts as the verifier decides it: by NT with one job, and by NT or N with more, where the two race. The old script failed a candidate for losing a claim in any encoding, including encodings the verifier never runs alone.differential.py, 462 files), verified by both builds at one job. Each function whose verdict changed isLOST(a proof or certified failure of the base the candidate does not give),FLIPPED(Verified in one and Failed in the other: someone is wrong),GAINED, orCHANGED; time changes over 2x and 5 s are listed.LOSTorFLIPPEDresult fails the gate..github/workflows/cppverify-z3-gate.ymlbuilds cpp-verify with the vendored Z3 and with the candidate (cloned at its tag,-DCPPVERIFY_Z3_SOURCE_DIR) in parallel, then runsgate.sh. It runs every Monday for Z3's newest release, by hand for any tag (z3_tag), and on a pull request that changes it, so this PR runs it for 5.3.2.Z3 5.3.2
Run locally (base: main with 4.13.4; candidate: main with 5.3.2):
5.3.2 no longer loses the 50-push chain's model that sank 5.1.0 in stage 1, and gains a proof there; on the test programs it loses what 4.16.0 and 5.1.0 lost (
even_mod,count_reverse,break_heap_wrong), and nothing flips. A second run gave the same results. Per decision Q4 (the newest release that passes the gate), 0.2 keeps 4.13.4; the weekly job says when one passes.Docs
third_party/README.md, "Upgrading Z3";Not done